Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 10825056: Update the `sandbox` documentation to point to new workflow docs. (Closed)

Created:
8 years, 4 months ago by Mike West
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Update the `sandbox` documentation to point to new workflow docs. BUG=117154 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148935

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mihai's feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -51 lines) Patch
M chrome/common/extensions/docs/apps/manifest.html View 1 4 chunks +25 lines, -17 lines 0 comments Download
M chrome/common/extensions/docs/extensions/manifest.html View 1 4 chunks +25 lines, -17 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 1 4 chunks +28 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Mihai, Aaron? Can you take a quick look? Should be trivial.
8 years, 4 months ago (2012-07-27 16:47:37 UTC) #1
Mihai Parparita -not on Chrome
LGTM http://codereview.chromium.org/10825056/diff/1/chrome/common/extensions/docs/extensions/manifest.html File chrome/common/extensions/docs/extensions/manifest.html (right): http://codereview.chromium.org/10825056/diff/1/chrome/common/extensions/docs/extensions/manifest.html#newcode984 chrome/common/extensions/docs/extensions/manifest.html:984: <a href="contentSecurityPolicy.html">Content Security Policy (CSP)</a> used The URL ...
8 years, 4 months ago (2012-07-29 19:24:15 UTC) #2
Mike West
8 years, 4 months ago (2012-07-29 19:44:48 UTC) #3
Done and done. I'll land this whenever the tree opens (like, tomorrow probably).

Thanks!

On 2012/07/29 19:24:15, Mihai Parparita wrote:
> LGTM
> 
>
http://codereview.chromium.org/10825056/diff/1/chrome/common/extensions/docs/...
> File chrome/common/extensions/docs/extensions/manifest.html (right):
> 
>
http://codereview.chromium.org/10825056/diff/1/chrome/common/extensions/docs/...
> chrome/common/extensions/docs/extensions/manifest.html:984: <a
> href="contentSecurityPolicy.html">Content Security Policy (CSP)</a> used
> The URL for this should be ../extensions/contentSecurityPolicy.html, since
that
> page doesn't exist in the apps docs family.
> 
>
http://codereview.chromium.org/10825056/diff/1/chrome/common/extensions/docs/...
> chrome/common/extensions/docs/extensions/manifest.html:1023: <a
> href="contentSecurityPolicy.html">default Content Security Policy</a>.
> Same.

Powered by Google App Engine
This is Rietveld 408576698