Update CNS to run on chromeperf34 and CNS tests to run on windows perf_av bot.

Update CNS to run on chromeperf34 and CNS tests to run on windows perf_av bot.

(Added OWNERS file to chrome/test/functional/media)

BUG=139262
NOTRY=true
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149695

[shadi, 2012-07-27 00:43:52]

Dale, PTAL.

[DaleCurtis, 2012-07-27 00:49:42]

https://chromiumcodereview.appspot.com/10825051/diff/1/chrome/test/functional...
File chrome/test/functional/media/cns_test_base.py (right):

https://chromiumcodereview.appspot.com/10825051/diff/1/chrome/test/functional...
chrome/test/functional/media/cns_test_base.py:18: WINDOWS = 'win32' in
sys.platform
Is this the right way to check this? Why not os.name == 'nt' ?

https://chromiumcodereview.appspot.com/10825051/diff/1/chrome/test/functional...
chrome/test/functional/media/cns_test_base.py:47: CNS_BASE_URL =
'http://127.0.0.1:%d/ServeConstrained?' % _CNS_PORT
if else block?

https://chromiumcodereview.appspot.com/10825051/diff/1/media/tools/constraine...
File media/tools/constrained_network_server/cns.py (right):

https://chromiumcodereview.appspot.com/10825051/diff/1/media/tools/constraine...
media/tools/constrained_network_server/cns.py:16: from logging import handlers
What does gpylint say about the ordering here?

https://chromiumcodereview.appspot.com/10825051/diff/1/media/tools/constraine...
media/tools/constrained_network_server/cns.py:331: file_handler =
handlers.RotatingFileHandler('cns.log', 'a', 10000000, 1000)
How will we see the logs on Linux now?

[shadi, 2012-07-27 01:06:24]

https://chromiumcodereview.appspot.com/10825051/diff/1/chrome/test/functional...
File chrome/test/functional/media/cns_test_base.py (right):

https://chromiumcodereview.appspot.com/10825051/diff/1/chrome/test/functional...
chrome/test/functional/media/cns_test_base.py:18: WINDOWS = 'win32' in
sys.platform
On 2012/07/27 00:49:43, DaleCurtis wrote:
> Is this the right way to check this? Why not os.name == 'nt' ?
I used sys.platform since I found it being used in chromium code search. But now
after you mentioned os.name, it seems it is used as well. 

I will do some research to see which is better.

https://chromiumcodereview.appspot.com/10825051/diff/1/chrome/test/functional...
chrome/test/functional/media/cns_test_base.py:47: CNS_BASE_URL =
'http://127.0.0.1:%d/ServeConstrained?' % _CNS_PORT
On 2012/07/27 00:49:43, DaleCurtis wrote:
> if else block?

Done.

https://chromiumcodereview.appspot.com/10825051/diff/1/media/tools/constraine...
File media/tools/constrained_network_server/cns.py (right):

https://chromiumcodereview.appspot.com/10825051/diff/1/media/tools/constraine...
media/tools/constrained_network_server/cns.py:16: from logging import handlers
On 2012/07/27 00:49:43, DaleCurtis wrote:
> What does gpylint say about the ordering here?
I did check gpylint, this is actually its recommended way.

https://chromiumcodereview.appspot.com/10825051/diff/1/media/tools/constraine...
media/tools/constrained_network_server/cns.py:331: file_handler =
handlers.RotatingFileHandler('cns.log', 'a', 10000000, 1000)
On 2012/07/27 00:49:43, DaleCurtis wrote:
> How will we see the logs on Linux now?
It should show as it currently does since locally I get the output on the screen
as well as log files. I would still need to run it on the bot to be 100% sure.

I reduced the total number of log files to 10 instead of 1000 (each up to 10MB).

[DaleCurtis, 2012-07-27 01:15:41]

lgtm

[commit-bot: I haz the power, 2012-08-02 18:32:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/10825051/5001

[commit-bot: I haz the power, 2012-08-02 18:32:22]

Presubmit check for 10825051-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/test/functional

Presubmit checks took 1.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Nirnimesh, 2012-08-02 18:38:37]

Runnberstamp LGTM

Please create OWNERS file for chrome/test/functional/media

[commit-bot: I haz the power, 2012-08-02 20:45:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/10825051/10001

[commit-bot: I haz the power, 2012-08-02 20:54:49]

Change committed as 149695