Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Issue 10825050: Introduce RootWindowHostDelegate. The RootWindowHost performs most of its communication with RootWi… (Closed)

Created:
8 years, 4 months ago by Ben Goodger (Google)
Modified:
8 years, 4 months ago
Reviewers:
oshima, Elliot Glaysher
CC:
chromium-reviews, tfarina, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Introduce RootWindowHostDelegate. The RootWindowHost performs most of its communication with RootWindow via this interface. The intent is to make the contract between RootWindowHost and RootWindow clearer. BUG=none TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148912

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -419 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 chunks +12 lines, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 12 chunks +30 lines, -30 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/event_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 93 chunks +107 lines, -107 lines 0 comments Download
M ui/aura/root_window.h View 5 chunks +16 lines, -16 lines 0 comments Download
M ui/aura/root_window.cc View 7 chunks +168 lines, -140 lines 0 comments Download
M ui/aura/root_window_host.h View 2 chunks +5 lines, -6 lines 0 comments Download
A ui/aura/root_window_host_delegate.h View 1 chunk +45 lines, -0 lines 0 comments Download
M ui/aura/root_window_host_linux.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/root_window_host_linux.cc View 15 chunks +35 lines, -37 lines 0 comments Download
M ui/aura/root_window_host_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/root_window_host_win.cc View 7 chunks +12 lines, -16 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 13 chunks +33 lines, -20 lines 0 comments Download
M ui/aura/shared/compound_event_filter_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/aura/shared/input_method_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/event_generator.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/aura/window_unittest.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ben Goodger (Google)
8 years, 4 months ago (2012-07-27 00:28:35 UTC) #1
Elliot Glaysher
+oshima, who asked about how this would affect his work yesterday.
8 years, 4 months ago (2012-07-27 16:29:29 UTC) #2
Elliot Glaysher
I'm fine with the patch, but I want to hear what oshima thinks first.
8 years, 4 months ago (2012-07-27 17:40:43 UTC) #3
oshima
I'm fine too. http://codereview.chromium.org/10825050/diff/1/ui/aura/root_window_host_linux.cc File ui/aura/root_window_host_linux.cc (right): http://codereview.chromium.org/10825050/diff/1/ui/aura/root_window_host_linux.cc#newcode585 ui/aura/root_window_host_linux.cc:585: delegate_->GetRootWindow()->ScheduleFullDraw(); I assume this is delegate_->AsRootWindow() ...
8 years, 4 months ago (2012-07-27 18:11:33 UTC) #4
Ben Goodger (Google)
OK. updated with fixes for unit tests etc. PTAL
8 years, 4 months ago (2012-07-27 21:30:11 UTC) #5
oshima
lgtm
8 years, 4 months ago (2012-07-27 21:39:23 UTC) #6
Elliot Glaysher
lgtm
8 years, 4 months ago (2012-07-27 22:30:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10825050/3004
8 years, 4 months ago (2012-07-28 22:02:48 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-07-29 03:30:10 UTC) #9
Change committed as 148912

Powered by Google App Engine
This is Rietveld 408576698