Update basic_media_playback tests to use media files in content/test/data

Update basic_media_playback tests to use media files in content/test/data

chrome/test/data/media files that were copied in r148190 in preparation for r148349

BUG=125424
NOTRY=true
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148756

[shadi, 2012-07-26 17:46:49]

Dale can you PTAL?

[DaleCurtis, 2012-07-26 17:49:52]

LGTM % nit.

https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
File chrome/test/functional/media/media_basic_playback.py (right):

https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
chrome/test/functional/media/media_basic_playback.py:25:
os.path.join(pyauto.PyUITest.ContentDataDir(), 'media', name)
'/'.join() or posixpath() ? :)

[shadi, 2012-07-26 17:55:31]

https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
File chrome/test/functional/media/media_basic_playback.py (right):

https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
chrome/test/functional/media/media_basic_playback.py:25:
os.path.join(pyauto.PyUITest.ContentDataDir(), 'media', name)
On 2012/07/26 17:49:52, DaleCurtis wrote:
> '/'.join() or posixpath() ? :)
I believe os.path.join is what we need here since we are directly pointing to a
file on the system and not using it in a URL or directing to a server that
interprets the parth...

[DaleCurtis, 2012-07-26 17:57:19]

On 2012/07/26 17:55:31, shadi wrote:
>
https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
> File chrome/test/functional/media/media_basic_playback.py (right):
> 
>
https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
> chrome/test/functional/media/media_basic_playback.py:25:
> os.path.join(pyauto.PyUITest.ContentDataDir(), 'media', name)
> On 2012/07/26 17:49:52, DaleCurtis wrote:
> > '/'.join() or posixpath() ? :)
> I believe os.path.join is what we need here since we are directly pointing to
a
> file on the system and not using it in a URL or directing to a server that
> interprets the parth...

Windows still uses file://../../ not file:\\..\..\ IIRC.

[shadi, 2012-07-26 18:11:22]

On 2012/07/26 17:57:19, DaleCurtis wrote:
> On 2012/07/26 17:55:31, shadi wrote:
> >
>
https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
> > File chrome/test/functional/media/media_basic_playback.py (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
> > chrome/test/functional/media/media_basic_playback.py:25:
> > os.path.join(pyauto.PyUITest.ContentDataDir(), 'media', name)
> > On 2012/07/26 17:49:52, DaleCurtis wrote:
> > > '/'.join() or posixpath() ? :)
> > I believe os.path.join is what we need here since we are directly pointing
to
> a
> > file on the system and not using it in a URL or directing to a server that
> > interprets the parth...
> 
> Windows still uses file://../../ not file:\\..\..\ IIRC.

Either way works on windows I believe (i just tested file:\\..\\ on win). 

Anyway, ContentDataDir() returns os.path.join(PyUITest.DataDir(), os.pardir,
os.pardir, os.pardir, 'content', 'test', 'data'), so I guess it is better not to
mix os paths forms in this case?

[DaleCurtis, 2012-07-26 20:09:05]

On 2012/07/26 18:11:22, shadi wrote:
> On 2012/07/26 17:57:19, DaleCurtis wrote:
> > On 2012/07/26 17:55:31, shadi wrote:
> > >
> >
>
https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
> > > File chrome/test/functional/media/media_basic_playback.py (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/10825038/diff/1003/chrome/test/functio...
> > > chrome/test/functional/media/media_basic_playback.py:25:
> > > os.path.join(pyauto.PyUITest.ContentDataDir(), 'media', name)
> > > On 2012/07/26 17:49:52, DaleCurtis wrote:
> > > > '/'.join() or posixpath() ? :)
> > > I believe os.path.join is what we need here since we are directly pointing
> to
> > a
> > > file on the system and not using it in a URL or directing to a server that
> > > interprets the parth...
> > 
> > Windows still uses file://../../ not file:\\..\..\ IIRC.
> 
> Either way works on windows I believe (i just tested file:\\..\\ on win). 
> 
> Anyway, ContentDataDir() returns os.path.join(PyUITest.DataDir(), os.pardir,
> os.pardir, os.pardir, 'content', 'test', 'data'), so I guess it is better not
to
> mix os paths forms in this case?

Should be file in any case. I just mentioned it because you mentioned having
problems with it yesterday :)

[commit-bot: I haz the power, 2012-07-26 20:21:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/10825038/1003

[commit-bot: I haz the power, 2012-07-26 20:21:55]

Presubmit check for 10825038-1003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/test/functional

[Nirnimesh, 2012-07-26 20:33:39]

LGTM

[commit-bot: I haz the power, 2012-07-26 22:57:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/10825038/1003

[commit-bot: I haz the power, 2012-07-26 22:59:47]

Try job failure for 10825038-1003 on linux_chromeos for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-07-27 00:30:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/10825038/1003

[Nirnimesh, 2012-07-27 00:33:36]

You can use "NOTRY=true" in the CL description. The tryjob results aren't useful
for this CL.

[commit-bot: I haz the power, 2012-07-27 03:00:31]

Try job failure for 10825038-1003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-07-27 16:28:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/10825038/1003

[commit-bot: I haz the power, 2012-07-27 16:37:27]

Change committed as 148756