Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: vm/flow_graph_compiler.cc

Issue 10825035: Add an explicit push-argument instruction to the IL. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/flow_graph_builder.cc ('k') | vm/flow_graph_compiler_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_compiler.cc
===================================================================
--- vm/flow_graph_compiler.cc (revision 9930)
+++ vm/flow_graph_compiler.cc (working copy)
@@ -599,7 +599,9 @@
locs->set_in(i, Location::RegisterLocation(reg));
}
- Pop(reg, instr->InputAt(i));
+ // Inputs are consumed from the simulated frame. In case of a call argument
+ // we leave it until the call instruction.
+ if (!instr->IsPushArgument()) Pop(reg, instr->InputAt(i));
}
// If this instruction is call spill everything that was not consumed by
« no previous file with comments | « vm/flow_graph_builder.cc ('k') | vm/flow_graph_compiler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698