Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: vm/flow_graph_compiler.cc

Issue 10825035: Add an explicit push-argument instruction to the IL. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/flow_graph_compiler.cc
===================================================================
--- vm/flow_graph_compiler.cc (revision 9930)
+++ vm/flow_graph_compiler.cc (working copy)
@@ -599,7 +599,7 @@
locs->set_in(i, Location::RegisterLocation(reg));
}
- Pop(reg, instr->InputAt(i));
+ if (!instr->IsPushArgument()) Pop(reg, instr->InputAt(i));
Kevin Millikin (Google) 2012/07/26 13:03:18 This deserves some small comment like: "Inputs are
Florian Schneider 2012/07/26 13:45:24 Done.
}
// If this instruction is call spill everything that was not consumed by

Powered by Google App Engine
This is Rietveld 408576698