Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: content/shell/android/javatests/content_shell_test_apk.xml

Issue 10825033: Check variable PRODUCT_DIR firstly for content shell test (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/android/javatests/content_shell_test_apk.xml
diff --git a/content/shell/android/javatests/content_shell_test_apk.xml b/content/shell/android/javatests/content_shell_test_apk.xml
index 497a81c9b6a0d13ba9a018f0bc496a1a711e0935..ad03afef2900d7200d5062a96aaee8ec72163a9f 100644
--- a/content/shell/android/javatests/content_shell_test_apk.xml
+++ b/content/shell/android/javatests/content_shell_test_apk.xml
@@ -33,18 +33,13 @@
<!-- We expect PRODUCT_DIR to be set like the gyp var
(e.g. $ROOT/out/Debug) -->
- <!-- TODO(satish): ideally we need this to run before -build-setup, where
- directories are made based on this variable. -->
- <target name="-pre-build">
- <if>
- <condition>
- <isset property="PRODUCT_DIR" />
- </condition>
- <else>
- <fail message="PRODUCT_DIR env var not set?" />
- </else>
- </if>
- </target>
+ <fail message="PRODUCT_DIR env var not set?">
+ <condition>
+ <not>
+ <isset property="PRODUCT_DIR"/>
+ </not>
+ </condition>
+ </fail>
<target name="-post-compile">
<!-- copy gdbserver to main libs directory if building debug.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698