Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 10825033: Check variable PRODUCT_DIR firstly for content shell test (Closed)

Created:
8 years, 5 months ago by yongsheng
Modified:
8 years, 4 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Check variable PRODUCT_DIR firstly for content shell test Simple fix like other build files BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M content/shell/android/javatests/content_shell_test_apk.xml View 1 chunk +7 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
yongsheng
trivial fix. please have a check.
8 years, 5 months ago (2012-07-26 09:15:56 UTC) #1
cjhopman
lgtm
8 years, 5 months ago (2012-07-26 17:34:18 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 5 months ago (2012-07-27 00:20:02 UTC) #3
yongsheng
yaron, could you please help review it? Thanks.
8 years, 5 months ago (2012-07-27 00:21:10 UTC) #4
Yaron
lgtm
8 years, 4 months ago (2012-07-27 17:49:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10825033/1
8 years, 4 months ago (2012-07-27 17:50:08 UTC) #6
commit-bot: I haz the power
Try job failure for 10825033-1 (previous was lost) on linux_chromeos for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=29349 Step ...
8 years, 4 months ago (2012-07-27 19:21:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10825033/1
8 years, 4 months ago (2012-07-29 13:08:24 UTC) #8
commit-bot: I haz the power
Try job failure for 10825033-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-07-29 15:51:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10825033/1
8 years, 4 months ago (2012-07-30 12:04:57 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 13:05:09 UTC) #11
Change committed as 148942

Powered by Google App Engine
This is Rietveld 408576698