Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: tools/json_schema_compiler/cpp_type_generator_test.py

Issue 10825029: Added JSON schema compiler support for serialized types (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/cpp_type_generator_test.py
diff --git a/tools/json_schema_compiler/cpp_type_generator_test.py b/tools/json_schema_compiler/cpp_type_generator_test.py
index a9408fa73002e51be17bfebf38c8730f64d4ec18..b048448ab517aa5134923c8882c4c51e2f2dd075 100755
--- a/tools/json_schema_compiler/cpp_type_generator_test.py
+++ b/tools/json_schema_compiler/cpp_type_generator_test.py
@@ -43,8 +43,9 @@ class CppTypeGeneratorTest(unittest.TestCase):
def testGenerateIncludesAndForwardDeclarations(self):
manager = CppTypeGenerator('', self.windows, self.windows.unix_name)
manager.AddNamespace(self.tabs, self.tabs.unix_name)
- self.assertEquals('#include "path/to/tabs.h"',
- manager.GenerateIncludes().Render())
+ self.assertEquals('#include "path/to/tabs.h"\n'
+ '#include "base/string_number_conversions.h"',
+ manager.GenerateIncludes().Render())
self.assertEquals(
'namespace tabs {\n'
'struct Tab;\n'
@@ -54,7 +55,8 @@ class CppTypeGeneratorTest(unittest.TestCase):
'} // windows',
manager.GenerateForwardDeclarations().Render())
manager = CppTypeGenerator('', self.permissions, self.permissions.unix_name)
- self.assertEquals('', manager.GenerateIncludes().Render())
+ self.assertEquals('#include "base/string_number_conversions.h"',
+ manager.GenerateIncludes().Render())
self.assertEquals('namespace permissions {\n'
'struct Permissions;\n'
'} // permissions',
@@ -73,8 +75,9 @@ class CppTypeGeneratorTest(unittest.TestCase):
'path/to/tabs.json')
manager = CppTypeGenerator('', windows, self.windows.unix_name)
manager.AddNamespace(tabs_namespace, self.tabs.unix_name)
- self.assertEquals('#include "path/to/tabs.h"',
- manager.GenerateIncludes().Render())
+ self.assertEquals('#include "path/to/tabs.h"\n'
+ '#include "base/string_number_conversions.h"',
+ manager.GenerateIncludes().Render())
self.assertEquals(
'namespace tabs {\n'
'struct Permissions;\n'
@@ -100,7 +103,8 @@ class CppTypeGeneratorTest(unittest.TestCase):
manager.AddNamespace(browser_action_namespace,
self.browser_action.unix_name)
self.assertEquals('#include "path/to/browser_action.h"\n'
- '#include "path/to/font_settings.h"',
+ '#include "path/to/font_settings.h"\n'
+ '#include "base/string_number_conversions.h"',
manager.GenerateIncludes().Render())
self.assertEquals(
'namespace browserAction {\n'

Powered by Google App Engine
This is Rietveld 408576698