Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 10825027: Turn on the fixed position stacking context flag by default (Closed)

Created:
8 years, 5 months ago by enne (OOO)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jamesr, wiltzius, Vangelis Kokkevis
Visibility:
Public.

Description

Turn on the fixed position stacking context flag by default Because there's an expectation that this flag will need to be reverted on a branch, add both the enable and the disable flags so that only web_contents_impl.cc will need to be touched to change the default value. Both can be removed later, once this setting sticks. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +9 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
enne (OOO)
8 years, 5 months ago (2012-07-26 00:10:45 UTC) #1
Ben Goodger (Google)
LGTM
8 years, 5 months ago (2012-07-26 00:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/10825027/1
8 years, 5 months ago (2012-07-26 01:17:43 UTC) #3
commit-bot: I haz the power
Presubmit check for 10825027-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-26 01:17:46 UTC) #4
enne (OOO)
+joi for OWNERS
8 years, 5 months ago (2012-07-26 01:26:35 UTC) #5
Jói
LGTM for content/public. On Thu, Jul 26, 2012 at 1:26 AM, <enne@chromium.org> wrote: > +joi ...
8 years, 5 months ago (2012-07-26 09:54:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/10825027/1
8 years, 5 months ago (2012-07-26 15:35:50 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 17:10:19 UTC) #8
Change committed as 148572

Powered by Google App Engine
This is Rietveld 408576698