Issue 10825020: Moved Discovery out of the Suggested Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825020: Moved Discovery out of the Suggested Page (Closed)

Created:
8 years, 5 months ago by srvasude1

Modified:
8 years, 5 months ago

Reviewers:
beaudoin, Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Moved Discovery out of the Suggested Page BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148564

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	chrome/browser/ui/webui/ntp/suggestions_combiner.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/suggestions_combiner.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/suggestions_page_handler.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

beaudoin

LGTM Added estade@ as a reviewer. Srinivas: Please run `git try` on this. Evan: Srinivas ...

8 years, 5 months ago (2012-07-25 22:38:15 UTC) #1

beaudoin

On 2012/07/25 22:38:15, beaudoin wrote: > LGTM > > Added estade@ as a reviewer. > ...

8 years, 5 months ago (2012-07-25 22:38:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srvasude@chromium.org/10825020/1

8 years, 5 months ago (2012-07-26 04:21:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srvasude@chromium.org/10825020/11002

8 years, 5 months ago (2012-07-26 15:33:43 UTC) #5

Change committed as 148564