Add GetSitesWithData and FreeSiteList methods to PPP_Flash_BrowserOperations interface and hook the…

ppapi/api/private/ppp_flash_browser_operations.idl

Index: ppapi/api/private/ppp_flash_browser_operations.idl
diff --git a/ppapi/api/private/ppp_flash_browser_operations.idl b/ppapi/api/private/ppp_flash_browser_operations.idl
index 4eeadb7d2c13671303cfcdb6b0dee322a12ad602..b06c6befa62a2a181812a77ac776b8ec68758596 100644
--- a/ppapi/api/private/ppp_flash_browser_operations.idl
+++ b/ppapi/api/private/ppp_flash_browser_operations.idl
@@ -9,7 +9,8 @@
 
 label Chrome {
   M20 = 1.0,
-  M21 = 1.2
+  M21 = 1.2,
+  M22 = 1.3
 };
 
 [assert_size(4)]
@@ -44,31 +45,54 @@ typedef void PPB_Flash_BrowserOperations_GetSettingsCallback(
  */
 interface PPP_Flash_BrowserOperations {
   /**
+   * Returns a list of sites that have stored data, for use with the

[brettw, 2012/07/25 23:17:03]

Can you put these new versions at the bottom?

I try to keep "point" revisions of interfaces the same as the previous version
but with additions at the bottom (so you can downcast safely).

[Bernhard Bauer, 2012/07/26 00:18:53]

Done.

+   * "Clear site data" feature.
+   *
+   * @param[in] plugin_data_path String containing the directory where the
+   * plugin data is stored.
+   * @param[out] sites A NULL-terminated array of sites that have stored data.
+   * Use FreeSiteList on the the array when done.
+   *
+   * See also the NPP_GetSitesWithData function in NPAPI:
+   * https://wiki.mozilla.org/NPAPI:ClearSiteData
+   */
+  [version=1.3]
+  void GetSitesWithData([in] str_t plugin_data_path,
+                        [out] str_t[] sites);

[brettw, 2012/07/25 23:17:03]

We need to define how the memory management works here. We say that the plugin
and system don't necessarily share the same allocator, so we don't want this.
Probably this function should just return a PP_Var that's a string.

Can you mention how the return value is formatted? (i.e. how the sites are
separated).

[yzshen1, 2012/07/25 23:56:24]

We couldn't use PP_Var in this interface, because the broker process doesn't
have var tracker.

[Bernhard Bauer, 2012/07/26 00:18:53]

The caller passes in the list of sites to FreeSiteList() afterwards to free it.
Allocation and deallocation are both done by Flash.
The outparam is an array of char*'s (which makes it a char***), not a single
string.

+
+  /**
+   * Frees the list of sites returned by GetSitesWithData.
+   *
+   * @param[in] sites A NULL-terminated array of strings.
+   */
+  [version=1.3]
+  void FreeSiteList([inout] str_t[] sites);

[brettw, 2012/07/25 23:17:03]

Ditto with the return value instead of out param.

+
+  /**
    * This function allows the plugin to implement the "Clear site data" feature.
    *
-   * @plugin_data_path String containing the directory where the plugin data is
+   * @param[in] plugin_data_path String containing the directory where the
+   * plugin data is
    * stored. On UTF16 systems (Windows), this will be encoded as UTF-8. It will
    * be an absolute path and will not have a directory separator (slash) at the
    * end.
-   *
-   * @arg site String specifying which site to clear the data for. This will
-   * be null to clear data for all sites.
-   *
-   * @arg flags Currently always 0 in Chrome to clear all data. This may be
-   * extended in the future to clear only specific types of data.
-   *
-   * @arg max_age The maximum age in seconds to clear data for. This allows the
-   * plugin to implement "clear past hour" and "clear past data", etc.
+   * @param[in] site String specifying which site to clear the data for. This
+   * will be null to clear data for all sites.
+   * @param[in] flags Currently always 0 in Chrome to clear all data. This may
+   * be extended in the future to clear only specific types of data.
+   * @param[in] max_age The maximum age in seconds to clear data for. This
+   * allows the plugin to implement "clear past hour" and "clear past data",
+   * etc.
    *
    * @return PP_TRUE on success, PP_FALSE on failure.
    *
    * See also the NPP_ClearSiteData function in NPAPI.
    * https://wiki.mozilla.org/NPAPI:ClearSiteData
    */
-  PP_Bool ClearSiteData(str_t plugin_data_path,
-                        str_t site,
-                        uint64_t flags,
-                        uint64_t max_age);
+  PP_Bool ClearSiteData([in] str_t plugin_data_path,
+                        [in] str_t site,
+                        [in] uint64_t flags,
+                        [in] uint64_t max_age);
 
   /**
    * Requests the plugin to deauthorize content licenses. It prevents Flash from