media/ffmpeg/ffmpeg_common.cc - Issue 10825014: Test variable against constant instead of simply testing constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/ffmpeg/ffmpeg_common.cc

Issue 10825014: Test variable against constant instead of simply testing constant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/ffmpeg/ffmpeg_common.cc

diff --git a/media/ffmpeg/ffmpeg_common.cc b/media/ffmpeg/ffmpeg_common.cc

index 919f124e8de7ce1bcaea83e32505cb75a6e2bcda..8c29c9bb938b6f0ac4751ebce093d3c60b514c21 100644

--- a/media/ffmpeg/ffmpeg_common.cc

+++ b/media/ffmpeg/ffmpeg_common.cc

@@ -248,7 +248,7 @@ void AVStreamToVideoDecoderConfig(

aspect_ratio = stream->codec->sample_aspect_ratio;

VideoCodec codec = CodecIDToVideoCodec(stream->codec->codec_id);

- VideoCodecProfile profile = kCodecVP8 ? VP8PROFILE_MAIN :

+ VideoCodecProfile profile = (codec == kCodecVP8) ? VP8PROFILE_MAIN :

ProfileIDToVideoCodecProfile(stream->codec->profile);

config->Initialize(codec,

profile,

« no previous file with comments | « no previous file | no next file » | no next file with comments »