Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: tools/isolate/trace_test_cases_smoke_test.py

Issue 10825010: Run_test_case.py now returns 1 when at least 1 test fails. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolate/run_test_cases_smoke_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/trace_test_cases_smoke_test.py
diff --git a/tools/isolate/trace_test_cases_smoke_test.py b/tools/isolate/trace_test_cases_smoke_test.py
index 88c2446f6e5c8cfa005218675269d8a2e2b8ca82..9fdfc27c66cfcf6506bf0f3c347b76ab9496d527 100755
--- a/tools/isolate/trace_test_cases_smoke_test.py
+++ b/tools/isolate/trace_test_cases_smoke_test.py
@@ -16,7 +16,9 @@ import trace_inputs
FILE_PATH = os.path.realpath(unicode(os.path.abspath(__file__)))
ROOT_DIR = os.path.dirname(FILE_PATH)
-TARGET_PATH = os.path.join(ROOT_DIR, 'data', 'gtest_fake', 'gtest_fake.py')
+TARGET_UTIL_PATH = os.path.join(ROOT_DIR, 'data', 'gtest_fake',
+ 'gtest_fake_base.py')
+TARGET_PATH = os.path.join(ROOT_DIR, 'data', 'gtest_fake', 'gtest_fake_fail.py')
class TraceTestCases(unittest.TestCase):
@@ -63,7 +65,13 @@ class TraceTestCases(unittest.TestCase):
u'executable': self.real_executable,
u'files': [
{
- u'path': os.path.join(u'data', 'gtest_fake', 'gtest_fake.py'),
+ u'path': os.path.join(u'data', 'gtest_fake',
+ 'gtest_fake_base.py'),
+ u'size': os.stat(TARGET_UTIL_PATH).st_size,
+ },
+ {
+ u'path': os.path.join(u'data', 'gtest_fake',
+ 'gtest_fake_fail.py'),
u'size': os.stat(TARGET_PATH).st_size,
},
],
@@ -73,7 +81,8 @@ class TraceTestCases(unittest.TestCase):
u'valid': True,
u'variables': {
u'isolate_dependency_tracked': [
- u'<(PRODUCT_DIR)/gtest_fake/gtest_fake.py',
+ u'<(PRODUCT_DIR)/gtest_fake/gtest_fake_base.py',
+ u'<(PRODUCT_DIR)/gtest_fake/gtest_fake_fail.py',
],
},
}
« no previous file with comments | « tools/isolate/run_test_cases_smoke_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698