Fix the failed case L10nUtilTest.GetAppLocale of ui unittests on Android

Fix the failed case L10nUtilTest.GetAppLocale of ui unittests on Android

There are 2 kinds of issues to make it failed:
1) pak files are stored in a different directory on Android other
than other platforms.
2) The setting and getting locale is different from Linux, but
similar with ChromiumOS.

BUG=
TEST=run_tests.py -s ui_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150261

[yongsheng, 2012-07-25 08:23:06]

I check the results. These 3 cases are all passed. seems there are many new
failures in the unit tests.

[yongsheng, 2012-07-25 09:13:03]

On 2012/07/25 08:23:06, yongsheng wrote:
> I check the results. These 3 cases are all passed. seems there are many new
> failures in the unit tests.
I mean new failures which are caused by other fixes.

[yongsheng, 2012-07-25 09:40:19]

> I mean new failures which are caused by other fixes.
I believe these failures are introduced by this commit:
b2910ab8d8861ae1cfa7b720e60a93e504a78729
Since android uses default skia rgba format(chrome on other platforms uses skia
argb format), many unit tests are failed. So we need to change the behavior of
these. I'll create a new patch for that.

commit b2910ab8d8861ae1cfa7b720e60a93e504a78729
Author: michaelbai@chromium.org
<michaelbai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Tue Jul 24 19:03:14 2012 +0000

    Upstream the rest of skia diff

    - Removed use-system-skia for android, as it didn't work now.
    - Combined multiple android condition into one.

[yongsheng, 2012-07-25 09:41:21]

On 2012/07/25 09:40:19, yongsheng wrote:
> > I mean new failures which are caused by other fixes.
> I believe these failures are introduced by this commit:
> b2910ab8d8861ae1cfa7b720e60a93e504a78729
> Since android uses default skia rgba format(chrome on other platforms uses
skia
> argb format), many unit tests are failed. So we need to change the behavior of
> these. I'll create a new patch for that.
> 
> commit b2910ab8d8861ae1cfa7b720e60a93e504a78729
> Author: mailto:michaelbai@chromium.org
> <michaelbai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
> Date:   Tue Jul 24 19:03:14 2012 +0000
> 
>     Upstream the rest of skia diff
> 
>     - Removed use-system-skia for android, as it didn't work now.
>     - Combined multiple android condition into one.
4 failures in ui_unittests and 10 failures in content_unittests.

[yongsheng, 2012-07-25 14:39:48]

> 4 failures in ui_unittests and 10 failures in content_unittests.
See the 13 cases except PNGCodec.EncodeBGRASkBitmapDiscardTransparency:
http://codereview.chromium.org/10823012/

[nilesh, 2012-07-25 17:41:50]

http://codereview.chromium.org/10825007/diff/1/ui/base/l10n/l10n_util_unittes...
File ui/base/l10n/l10n_util_unittest.cc (right):

http://codereview.chromium.org/10825007/diff/1/ui/base/l10n/l10n_util_unittes...
ui/base/l10n/l10n_util_unittest.cc:91: // base::DIR_ANDROID_APP_DATA. See
ResourceBundle::GetLocaleFilePath.
I think we should modify ui/base/ui_base_paths.cc to return the correct
DIR_LOCALES for android. This way we won't have this ifdef android in two
places.

[tony, 2012-07-25 22:24:48]

On 2012/07/25 17:41:50, nileshagrawal1 wrote:
>
http://codereview.chromium.org/10825007/diff/1/ui/base/l10n/l10n_util_unittes...
> File ui/base/l10n/l10n_util_unittest.cc (right):
> 
>
http://codereview.chromium.org/10825007/diff/1/ui/base/l10n/l10n_util_unittes...
> ui/base/l10n/l10n_util_unittest.cc:91: // base::DIR_ANDROID_APP_DATA. See
> ResourceBundle::GetLocaleFilePath.
> I think we should modify ui/base/ui_base_paths.cc to return the correct
> DIR_LOCALES for android. This way we won't have this ifdef android in two
> places.

This sounds better to me too.

[yongsheng, 2012-07-26 01:25:39]

On 2012/07/25 17:41:50, nileshagrawal1 wrote:
>
http://codereview.chromium.org/10825007/diff/1/ui/base/l10n/l10n_util_unittes...
> File ui/base/l10n/l10n_util_unittest.cc (right):
> 
>
http://codereview.chromium.org/10825007/diff/1/ui/base/l10n/l10n_util_unittes...
> ui/base/l10n/l10n_util_unittest.cc:91: // base::DIR_ANDROID_APP_DATA. See
> ResourceBundle::GetLocaleFilePath.
> I think we should modify ui/base/ui_base_paths.cc to return the correct
> DIR_LOCALES for android. This way we won't have this ifdef android in two
> places.
that's great. I'll change it.
thanks, tony and nileshagrawal1.

[yongsheng, 2012-07-26 06:57:21]

done with your comments. 
implement it with previous directory.

[yongsheng, 2012-07-26 08:40:00]

On 2012/07/26 06:57:21, yongsheng wrote:
> done with your comments. 
> implement it with previous directory.
the failure case is "RenderWidgetTest.OnMsgPaintAtSize" which is suppressed by
"5b21f647de12e3116".

[nilesh, 2012-07-26 15:04:03]

LGTM.

[tony, 2012-07-26 18:17:21]

LGTM2

[yongsheng, 2012-07-27 00:03:26]

On 2012/07/26 18:17:21, tony wrote:
> LGTM2
thank you all.

[commit-bot: I haz the power, 2012-07-27 00:04:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10825007/4003

[commit-bot: I haz the power, 2012-07-27 00:04:12]

Presubmit check for 10825007-4003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ui

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[yongsheng, 2012-07-27 00:18:36]

On 2012/07/27 00:04:12, I haz the power (commit-bot) wrote:
> Presubmit check for 10825007-4003 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for files in these directories:
>     ui
> 
> Was the presubmit check useful? Please send feedback & hate mail to
> maruel@chromium.org!
hi, sky, since you are the owner of ui, could you please help review it? Thanks.

[yongsheng, 2012-07-29 01:05:03]

sky, or anyone who can help review it? thanks

[sky, 2012-08-01 04:00:50]

LGTM

[commit-bot: I haz the power, 2012-08-06 01:35:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10825007/4003

[commit-bot: I haz the power, 2012-08-06 01:36:02]

Failed to apply patch for build/android/gtest_filter/ui_unittests_disabled:
While running patch -p1 --forward --force;
patching file build/android/gtest_filter/ui_unittests_disabled
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file
build/android/gtest_filter/ui_unittests_disabled.rej

[commit-bot: I haz the power, 2012-08-06 02:37:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10825007/2006

[commit-bot: I haz the power, 2012-08-06 02:55:25]

Try job failure for 10825007-2006 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-07 01:20:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10825007/2006

[commit-bot: I haz the power, 2012-08-07 04:00:13]

Change committed as 150261