Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 10825005: Fix UninitCondition in TrackRunIterator tests. (Closed)

Created:
8 years, 5 months ago by DaleCurtis
Modified:
8 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix UninitCondition in TrackRunIterator tests. UninitCondition Conditional jump or move depends on uninitialised value(s) media::mp4::TrackRunIterator::Init(media::mp4::MovieFragment const&) (media/mp4/track_run_iterator.cc:134) media::mp4::TrackRunIteratorTest_BasicOperationTest_Test::TestBody() (media/mp4/track_run_iterator_unittest.cc:114) Uninitialised value was created by a stack allocation media::mp4::TrackRunIteratorTest::CreateFragment() (media/mp4/track_run_iterator_unittest.cc:62) BUG=none TEST=media_unittests + valgrind. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/mp4/track_run_iterator_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
PTAL. Found while testing next FFmpeg roll. Not sure why the bots didn't pick it ...
8 years, 5 months ago (2012-07-25 00:42:54 UTC) #1
strobe_
On 2012/07/25 00:42:54, DaleCurtis wrote: > PTAL. Found while testing next FFmpeg roll. Not sure ...
8 years, 5 months ago (2012-07-25 00:45:13 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
8 years, 5 months ago (2012-07-25 00:55:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/10825005/1
8 years, 5 months ago (2012-07-25 00:58:39 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 02:36:15 UTC) #5
Change committed as 148284

Powered by Google App Engine
This is Rietveld 408576698