Issue 10825002: Separate debug shortcuts into another array in ash accelerator table.

Issue 10825002: Separate debug shortcuts into another array in ash accelerator table. (Closed)

Created:
8 years, 5 months ago by mazda

Modified:
8 years, 5 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Separate debug shortcuts into another array in ash accelerator table. BUG=138739 TEST=Manually check debug shortcuts work with --ash-debug-shortcuts enabled and do not work otherwise. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148285

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : address comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -33 lines)			Patch
M	ash/accelerators/accelerator_controller.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_controller.cc	View		7 chunks	+21 lines, -27 lines	0 comments	Download
M	ash/accelerators/accelerator_table.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	1 2 3	3 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

http://codereview.chromium.org/10825002/diff/7001/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): http://codereview.chromium.org/10825002/diff/7001/ash/accelerators/accelerator_table.cc#newcode40 ash/accelerators/accelerator_table.cc:40: { true, ui::VKEY_TAB, nit: mind unwrapping this line? http://codereview.chromium.org/10825002/diff/7001/ash/accelerators/accelerator_table.cc#newcode156 ...

8 years, 5 months ago (2012-07-25 00:00:19 UTC) #2

mazda

Could you have another look at the change? http://codereview.chromium.org/10825002/diff/7001/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): http://codereview.chromium.org/10825002/diff/7001/ash/accelerators/accelerator_table.cc#newcode40 ash/accelerators/accelerator_table.cc:40: { ...

8 years, 5 months ago (2012-07-25 00:20:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10825002/6003

8 years, 5 months ago (2012-07-25 01:04:08 UTC) #5

Change committed as 148285

Expand Messages | Collapse Messages