Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: tools/isolate/trace_inputs.py

Issue 10824409: Fix LogMan tracer to work correctly when process ids are reused. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/trace_inputs.py
diff --git a/tools/isolate/trace_inputs.py b/tools/isolate/trace_inputs.py
index a24fde428b8b9dd30cc6fc1cac651140a36d1aaa..05c652be0b7e8b8517f1f0893b73cb37405b8493 100755
--- a/tools/isolate/trace_inputs.py
+++ b/tools/isolate/trace_inputs.py
@@ -2456,7 +2456,7 @@ class LogmanTrace(ApiBase):
def handle_Process_End(self, line):
pid = line[self.PID]
- if pid in self._process_lookup:
+ if self._process_lookup.get(pid):
logging.info('Terminated: %d' % pid)
self._process_lookup[pid] = None
else:
@@ -2491,7 +2491,7 @@ class LogmanTrace(ApiBase):
proc = self.Process(self.blacklist, pid, None)
self.root_process = proc
ppid = None
- elif ppid in self._process_lookup:
+ elif self._process_lookup.get(ppid):
proc = self.Process(self.blacklist, pid, None)
self._process_lookup[ppid].children.append(proc)
else:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698