Issue 10824409: Fix LogMan tracer to work correctly when process ids are reused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824409: Fix LogMan tracer to work correctly when process ids are reused. (Closed)

Created:
8 years, 4 months ago by M-A Ruel

Modified:
8 years, 4 months ago

Reviewers:
cmp

CC:
chromium-reviews, pam+watch_chromium.org, csharp

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix LogMan tracer to work correctly when process ids are reused. Reproduced with: isolate.py trace -r .../net_unittests.results isolate.py read -r .../net_unittests.results It happens randomly whenever Windows decides to reuse a process id so it tends to happens often with browser_tests. This happened because stale processes are not removed from the map but set to None instead. R=cmp@chromium.org NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152755

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/isolate/trace_inputs.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10824409/1

8 years, 4 months ago (2012-08-22 11:59:13 UTC) #3

Change committed as 152755

Expand Messages | Collapse Messages