Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10824392: Fix queries for Dart's clas Obbject cid: get object class from object store and get its cid. This i… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 10998)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -244,9 +244,11 @@
LocationSummary* EqualityCompareComp::MakeLocationSummary() const {
+ const intptr_t dart_object_cid =
+ Class::Handle(Isolate::Current()->object_store()->object_class()).id();
const intptr_t kNumInputs = 2;
const bool is_checked_strict_equal =
- HasICData() && ic_data()->AllTargetsHaveSameOwner(kInstanceCid);
+ HasICData() && ic_data()->AllTargetsHaveSameOwner(dart_object_cid);
if ((receiver_class_id() == kSmiCid) ||
(receiver_class_id() == kDoubleCid) ||
is_checked_strict_equal) {
@@ -646,8 +648,10 @@
deopt_id(), token_pos(), try_index());
return;
}
+ const intptr_t dart_object_cid =
+ Class::Handle(Isolate::Current()->object_store()->object_class()).id();
const bool is_checked_strict_equal =
- HasICData() && ic_data()->AllTargetsHaveSameOwner(kInstanceCid);
+ HasICData() && ic_data()->AllTargetsHaveSameOwner(dart_object_cid);
if (is_checked_strict_equal) {
EmitCheckedStrictEqual(compiler, *ic_data(), *locs(), kind(), NULL,
deopt_id(), token_pos(), try_index());
@@ -2068,8 +2072,10 @@
static bool IsCheckedStrictEquals(const ICData& ic_data, Token::Kind kind) {
+ const intptr_t dart_object_cid =
+ Class::Handle(Isolate::Current()->object_store()->object_class()).id();
if ((kind == Token::kEQ) || (kind == Token::kNE)) {
- return ic_data.AllTargetsHaveSameOwner(kInstanceCid);
+ return ic_data.AllTargetsHaveSameOwner(dart_object_cid);
}
return false;
}
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698