Retry channel setup for NPAPI plugins.

content/renderer/webplugin_delegate_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/webplugin_delegate_proxy.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #elif defined(USE_X11)
 #include <cairo/cairo.h>
@@ skipping 283 matching lines @@
   // Anything else is a named, opaque color or an RGB form with no alpha.
   return false;
 }
 
 bool WebPluginDelegateProxy::Initialize(
     const GURL& url,
     const std::vector<std::string>& arg_names,
     const std::vector<std::string>& arg_values,
     webkit::npapi::WebPlugin* plugin,
     bool load_manually) {
+  // TODO(shess): Attempt to work around http://crbug.com/97285 and
+  // http://crbug.com/141055 by retrying the connection.  Reports seem
+  // to indicate that the plugin hasn't crashed, and that the problem
+  // is not 100% persistent.
+  const size_t kAttempts = 2;
+
+  bool result = false;
+  scoped_refptr<PluginChannelHost> channel_host;
+  int instance_id = 0;
+
+  for (size_t attempt = 0; !result && attempt < kAttempts; attempt++) {
 #if defined(OS_MACOSX)
-  // TODO(shess): Debugging for http://crbug.com/97285 .  See comment
-  // in plugin_channel_host.cc.
-  scoped_ptr<AutoReset<bool> > track_nested_removes(new AutoReset<bool>(
-      PluginChannelHost::GetRemoveTrackingFlag(), true));
+    // TODO(shess): Debugging for http://crbug.com/97285 .  See comment
+    // in plugin_channel_host.cc.
+    scoped_ptr<AutoReset<bool> > track_nested_removes(new AutoReset<bool>(
+        PluginChannelHost::GetRemoveTrackingFlag(), true));
 #endif
 
-  IPC::ChannelHandle channel_handle;
-  if (!RenderThreadImpl::current()->Send(new ViewHostMsg_OpenChannelToPlugin(
-          render_view_->routing_id(), url, page_url_, mime_type_,
-          &channel_handle, &info_))) {
-    return false;
+    IPC::ChannelHandle channel_handle;
+    if (!RenderThreadImpl::current()->Send(new ViewHostMsg_OpenChannelToPlugin(
+            render_view_->routing_id(), url, page_url_, mime_type_,
+            &channel_handle, &info_))) {
+      continue;
+    }
+
+    if (channel_handle.name.empty()) {
+      // We got an invalid handle.  Either the plugin couldn't be found (which
+      // shouldn't happen, since if we got here the plugin should exist) or the
+      // plugin crashed on initialization.
+      if (!info_.path.empty()) {
+        render_view_->PluginCrashed(info_.path);
+        LOG(ERROR) << "Plug-in crashed on start";
+
+        // Return true so that the plugin widget is created and we can paint the
+        // crashed plugin there.
+        return true;
+      }
+      LOG(ERROR) << "Plug-in couldn't be found";
+      return false;
+    }
+
+    channel_host =
+        PluginChannelHost::GetPluginChannelHost(
+            channel_handle, ChildProcess::current()->io_message_loop_proxy());
+    if (!channel_host.get()) {
+      LOG(ERROR) << "Couldn't get PluginChannelHost";
+      continue;
+    }
+#if defined(OS_MACOSX)
+    track_nested_removes.reset();
+#endif
+
+    {
+      // TODO(bauerb): Debugging for http://crbug.com/141055.
+      ScopedLogLevel log_level(-2);  // Equivalent to --v=2
+      result = channel_host->Send(new PluginMsg_CreateInstance(
+          mime_type_, &instance_id));
+      if (!result) {
+        LOG(ERROR) << "Couldn't send PluginMsg_CreateInstance";
+        continue;
+      }
+    }
   }
 
-  if (channel_handle.name.empty()) {
-    // We got an invalid handle.  Either the plugin couldn't be found (which
-    // shouldn't happen, since if we got here the plugin should exist) or the
-    // plugin crashed on initialization.
-    if (!info_.path.empty()) {
-      render_view_->PluginCrashed(info_.path);
-      LOG(ERROR) << "Plug-in crashed on start";
-
-      // Return true so that the plugin widget is created and we can paint the
-      // crashed plugin there.
-      return true;
-    }
-    LOG(ERROR) << "Plug-in couldn't be found";
+  // Failed too often, give up.
+  if (!result)
     return false;
-  }
-
-  scoped_refptr<PluginChannelHost> channel_host(
-      PluginChannelHost::GetPluginChannelHost(
-          channel_handle, ChildProcess::current()->io_message_loop_proxy()));
-  if (!channel_host.get()) {
-    LOG(ERROR) << "Couldn't get PluginChannelHost";
-    return false;
-  }
-#if defined(OS_MACOSX)
-  track_nested_removes.reset();
-#endif
-
-  int instance_id;
-  {
-    // TODO(bauerb): Debugging for http://crbug.com/141055.
-    ScopedLogLevel log_level(-2);  // Equivalent to --v=2
-    bool result = channel_host->Send(new PluginMsg_CreateInstance(
-        mime_type_, &instance_id));
-    if (!result) {
-      LOG(ERROR) << "Couldn't send PluginMsg_CreateInstance";
-      return false;
-    }
-  }
 
   channel_host_ = channel_host;
   instance_id_ = instance_id;
 
   channel_host_->AddRoute(instance_id_, this, NULL);
 
   // Now tell the PluginInstance in the plugin process to initialize.
   PluginMsg_Init_Params params;
   params.containing_window = render_view_->host_window();
   params.url = url;
@@ skipping 11 matching lines @@
         LowerCaseEqualsASCII(arg_values[i], "transparent")) ||
         (silverlight && LowerCaseEqualsASCII(arg_names[i], "background") &&
          SilverlightColorIsTransparent(arg_values[i]))) {
       transparent_ = true;
     }
   }
   params.load_manually = load_manually;
 
   plugin_ = plugin;
 
-  bool result = false;
+  result = false;
   IPC::Message* msg = new PluginMsg_Init(instance_id_, params, &result);
   Send(msg);
 
   if (!result)
     LOG(ERROR) << "PluginMsg_Init returned false";
 
   render_view_->RegisterPluginDelegate(this);
 
   return result;
 }
@@ skipping 1115 matching lines @@
 }
 #endif
 
 void WebPluginDelegateProxy::OnURLRedirectResponse(bool allow,
                                                    int resource_id) {
   if (!plugin_)
     return;
 
   plugin_->URLRedirectResponse(allow, resource_id);
 }