Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/compiler/implementation/ssa/types_propagation.dart

Issue 10824371: Add an optional parameter to the dominatedUsers function in case we want to analyze the whole block, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/compiler/implementation/ssa/optimize.dart ('K') | « lib/compiler/implementation/ssa/optimize.dart ('k') | tests/compiler/dart2js/dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/types_propagation.dart
===================================================================
--- lib/compiler/implementation/ssa/types_propagation.dart (revision 10938)
+++ lib/compiler/implementation/ssa/types_propagation.dart (working copy)
@@ -140,8 +140,7 @@
HTypeConversion converted =
new HTypeConversion.argumentTypeCheck(type, input);
instruction.block.addBefore(instruction, converted);
- instruction.changeUse(input, converted);
- Set<HInstruction> dominatedUsers = input.dominatedUsers(converted);
+ Set<HInstruction> dominatedUsers = input.dominatedUsers(instruction);
for (HInstruction user in dominatedUsers) {
user.changeUse(input, converted);
addToWorkList(user);
« lib/compiler/implementation/ssa/optimize.dart ('K') | « lib/compiler/implementation/ssa/optimize.dart ('k') | tests/compiler/dart2js/dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698