Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10824371: Add an optional parameter to the dominatedUsers function in case we want to analyze the whole block, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/nodes.dart
===================================================================
--- lib/compiler/implementation/ssa/nodes.dart (revision 10938)
+++ lib/compiler/implementation/ssa/nodes.dart (working copy)
@@ -932,7 +932,7 @@
}
// Compute the set of users of this instruction that is dominated by
- // [other].
+ // [other], [other] included.
kasperl 2012/08/20 12:58:35 Maybe explain this a bit better. Like: If [other]
ngeoffray 2012/08/20 13:01:32 Done.
Set<HInstruction> dominatedUsers(HInstruction other) {
// Keep track of all instructions that we have to deal with later
// and count the number of them that are in the current block.
@@ -944,7 +944,7 @@
HBasicBlock otherBlock = other.block;
for (int i = 0, length = usedBy.length; i < length; i++) {
HInstruction current = usedBy[i];
- if (current !== other && otherBlock.dominates(current.block)) {
+ if (otherBlock.dominates(current.block)) {
if (current.block === otherBlock) usersInCurrentBlock++;
users.add(current);
}
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/optimize.dart » ('j') | lib/compiler/implementation/ssa/optimize.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698