Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 10824366: Fix RGBA pixel layout when reading image from clipboard. (Closed)

Created:
8 years, 4 months ago by Xianzhu
Modified:
8 years, 4 months ago
Reviewers:
tony
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, dcheng
Visibility:
Public.

Description

Fix RGBA pixel layout when reading image from clipboard. Pixel layout on Android is RGBA. Original patch was created by zhenghao@ in Android downstream. The changed code is used in webkit unit tests, layout tests and test_shell. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M webkit/tools/test_shell/mock_webclipboard_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Xianzhu
8 years, 4 months ago (2012-08-17 23:25:14 UTC) #1
tony
LGTM, this is just used by tests and test_shell, right?
8 years, 4 months ago (2012-08-20 18:33:03 UTC) #2
Xianzhu
On 2012/08/20 18:33:03, tony wrote: > LGTM, this is just used by tests and test_shell, ...
8 years, 4 months ago (2012-08-20 18:38:47 UTC) #3
tony
On 2012/08/20 18:38:47, Xianzhu wrote: > On 2012/08/20 18:33:03, tony wrote: > > LGTM, this ...
8 years, 4 months ago (2012-08-20 18:47:51 UTC) #4
Xianzhu
On 2012/08/20 18:47:51, tony wrote: > On 2012/08/20 18:38:47, Xianzhu wrote: > > On 2012/08/20 ...
8 years, 4 months ago (2012-08-20 18:55:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10824366/1
8 years, 4 months ago (2012-08-20 18:55:52 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 23:44:14 UTC) #7
Change committed as 152424

Powered by Google App Engine
This is Rietveld 408576698