chrome/browser/extensions/image_loading_tracker.cc - Issue 10824359: Remove ImageSkia::empty and ImageSkia::extractSubset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/image_loading_tracker.cc

Issue 10824359: Remove ImageSkia::empty and ImageSkia::extractSubset (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/image_loading_tracker.cc

diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc

index 2500988c7494febe8296a60196b59577994e5cb0..7e620e634a8279c6b287ced46d22d76df82a5a76 100644

--- a/chrome/browser/extensions/image_loading_tracker.cc

+++ b/chrome/browser/extensions/image_loading_tracker.cc

@@ -372,7 +372,7 @@ void ImageLoadingTracker::OnBitmapLoaded(

gfx::Image image;

std::string extension_id = info->extension_id;

- if (!info->image_skia.empty())

+ if (!info->image_skia.isNull())

image = gfx::Image(info->image_skia);

load_map_.erase(load_map_it);