Remove ImageSkia::empty and ImageSkia::extractSubset

The way that ImageSkia::empty has been implemented, it is equivalent to ImageSkia::isNull. Replaced all instances of ImageSkia::empty with ImageSkia::isNull
Removed ImageSkia::extractSubset, and replaced calls to use ImageSkiaOperations::ExtractSubset instead

BUG=None
Test=Compiles, try bots pass.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152731

[pkotwicz, 2012-08-20 15:42:58]

The way that ImageSkia::empty has been implemented, it is equivalent to
ImageSkia::isNull. Replaced all instances of ImageSkia::empty with
ImageSkia::isNull (except when there is an ImageSkiaSource, but that's a bug)
Removed ImageSkia::extractSubset, and replaced calls to use
ImageSkiaOperations::ExtractSubset instead

[sky, 2012-08-20 16:57:16]

Peter mentioned this is a temporary step. We're going to rename isNull to empty
next. LGTM

[commit-bot: I haz the power, 2012-08-20 21:00:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10824359/6004

[commit-bot: I haz the power, 2012-08-20 22:15:04]

Try job failure for 10824359-6004 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-21 17:40:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10824359/6004

[commit-bot: I haz the power, 2012-08-21 17:51:57]

Failed to apply patch for
chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc
Hunk #1 FAILED at 215.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc.rej

[commit-bot: I haz the power, 2012-08-21 17:58:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10824359/8005

[commit-bot: I haz the power, 2012-08-21 17:58:50]

Failed to apply patch for
chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc
Hunk #1 FAILED at 215.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc.rej

[commit-bot: I haz the power, 2012-08-21 18:58:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10824359/54

[commit-bot: I haz the power, 2012-08-21 19:23:45]

Try job failure for 10824359-54 (retry) on mac for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2012-08-21 20:42:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10824359/9014

[commit-bot: I haz the power, 2012-08-21 20:56:57]

Try job failure for 10824359-9014 (retry) on mac for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2012-08-21 23:03:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10824359/19001

[commit-bot: I haz the power, 2012-08-22 04:11:25]

Change committed as 152731