Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 10824353: Update documentation comments in field_trial.h. (Closed)

Created:
8 years, 4 months ago by Alexei Svitkine (slow)
Modified:
8 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, MAD, erikwright+watch_chromium.org, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org
Visibility:
Public.

Description

Update documentation comments in field_trial.h. Adds missing parameter to FactoryGetFieldTrial() and changes group id values to not use kConstant naming convention since their values are dynamic. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M base/metrics/field_trial.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
8 years, 4 months ago (2012-08-17 15:04:07 UTC) #1
Ilya Sherman
lgtm
8 years, 4 months ago (2012-08-17 18:10:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10824353/1
8 years, 4 months ago (2012-08-17 18:12:14 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 22:43:12 UTC) #4
Change committed as 152179

Powered by Google App Engine
This is Rietveld 408576698