Issue 10824351: [content shell] Add support for layout tests using content_shell on Android (first step).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824351: [content shell] Add support for layout tests using content_shell on Android (first step). (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 4 months ago

Reviewers:
jam, Xianzhu

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[content shell] Add support for layout tests using content_shell on Android (first step). Added support for dumping pixel results, and signalling the server that we're ready. BUG=111316 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152202

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -21 lines)			Patch
M	content/shell/layout_test_controller.cc	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	content/shell/layout_test_controller_host.cc	View	3 chunks	+21 lines, -14 lines	0 comments	Download
M	content/shell/shell_browser_main.cc	View	3 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

On 2012/08/17 14:04:56, jochen wrote: > plz review LGTM. Thanks!

8 years, 4 months ago (2012-08-17 16:11:28 UTC) #2

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

8 years, 4 months ago (2012-08-17 16:43:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10824351/1

8 years, 4 months ago (2012-08-17 19:32:02 UTC) #6

Change committed as 152202

Expand Messages | Collapse Messages