Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: runtime/vm/compiler.cc

Issue 10824349: Implement class id checks as a separate instruction and add a local CSE optimization pass. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 10885)
+++ runtime/vm/compiler.cc (working copy)
@@ -35,6 +35,7 @@
DEFINE_FLAG(bool, trace_bailout, false, "Print bailout from ssa compiler.");
DEFINE_FLAG(bool, trace_compiler, false, "Trace compiler operations.");
DEFINE_FLAG(bool, use_ssa, true, "Use SSA form");
+DEFINE_FLAG(bool, local_cse, true, "Do local subexpression elimination.");
DEFINE_FLAG(int, deoptimization_counter_threshold, 5,
"How many times we allow deoptimization before we disallow"
" certain optimizations");
@@ -177,17 +178,23 @@
}
if (optimized) {
- FlowGraphOptimizer optimizer(*flow_graph);
+ FlowGraphOptimizer optimizer(*flow_graph, use_ssa);
optimizer.ApplyICData();
// Propagate types and eliminate more type tests.
FlowGraphTypePropagator propagator(*flow_graph, optimized && use_ssa);
propagator.PropagateTypes();
- // Do optimizations that depend on the propagated type information.
- optimizer.OptimizeComputations();
if (use_ssa) {
+ // Do optimizations that depend on the propagated type information.
+ optimizer.OptimizeComputations();
+
+ if (FLAG_local_cse) {
+ LocalCSE local_cse(*flow_graph);
+ local_cse.Optimize();
+ }
+
// Perform register allocation on the SSA graph.
FlowGraphAllocator allocator(*flow_graph);
allocator.AllocateRegisters();
« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698