Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 10824346: Don't recursively acquire lock inside UserManagerImplWrapper (Closed)

Created:
8 years, 4 months ago by Dmitry Polukhin
Modified:
8 years, 4 months ago
Reviewers:
bshe
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Don't recursively acquire lock inside UserManagerImplWrapper This CL moves out UserManager::Get() from WallpaperManager::SaveUserWallpaperProperties to caller code that should decide if the changes should be persistent or not. I'm not very well familiar with this code so please feel free to ignore this CL and propose different solution. I did this patch just as quick fix for P0 issue. BUG=142440 TEST=in "Local State" remove section UserWallpapersProperties to trigger migration

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M chrome/browser/chromeos/login/user_manager_impl.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bshe
thanks for this quick fix. In the long term, I think the ephemeral user check ...
8 years, 4 months ago (2012-08-17 13:02:29 UTC) #1
Dmitry Polukhin
8 years, 4 months ago (2012-08-17 13:06:56 UTC) #2
Feel free to ignore it and commit your solution.

Powered by Google App Engine
This is Rietveld 408576698