Renamed ExtensionIdSet to ExtensionIds

Renamed ExtensionIdSet to ExtensionIds


BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152173

[not at google - send to devlin, 2012-08-17 01:02:03]

why?

[yefimt, 2012-08-17 01:03:58]

On 2012/08/17 01:02:03, kalman wrote:
> why?

pkasting@ asked me to do it during different CL review.
Because it is not a set.

[not at google - send to devlin, 2012-08-17 01:04:55]

typedef std::set<std::string> ExtensionIdSet

how is that not a set?

[not at google - send to devlin, 2012-08-17 01:10:30]

Chatting to Yefim offline, the problem appears to be that there are two
ExtensionIdSet typedefs, one in exnteison.h and the other in extension_prefs.h,
the latter not being a set.

Perhaps we should add an ExtensionIdList to extension.h and replace uses of
ExtensionPrefs::ExtensionIdSet with extensions::ExtensionIdList.

[yefimt, 2012-08-17 01:21:48]

On 2012/08/17 01:10:30, kalman wrote:
> Chatting to Yefim offline, the problem appears to be that there are two
> ExtensionIdSet typedefs, one in exnteison.h and the other in
extension_prefs.h,
> the latter not being a set.
> 
> Perhaps we should add an ExtensionIdList to extension.h and replace uses of
> ExtensionPrefs::ExtensionIdSet with extensions::ExtensionIdList.

Done, I kept it in extension_prefs as logically it belongs to that context.

[not at google - send to devlin, 2012-08-17 01:30:06]

I mean

extensions::ExtensionPrefs::ExtensionIds

is so much longer than just

std::vector<std::set>

and I would point out that while "ExtensionIdSet" is wrong, "ExtensionIds" isn't
particularly descriptive either. And that a vector-of-strings is suitably
generic to be able to go in Extension IMO.

but sure, lgtm.

[not at google - send to devlin, 2012-08-17 01:30:20]

On 2012/08/17 01:30:06, kalman wrote:
> I mean
> 
> extensions::ExtensionPrefs::ExtensionIds
> 
> is so much longer than just
> 
> std::vector<std::set>
> 
> and I would point out that while "ExtensionIdSet" is wrong, "ExtensionIds"
isn't
> particularly descriptive either. And that a vector-of-strings is suitably
> generic to be able to go in Extension IMO.
> 
> but sure, lgtm.

s/set/string/

[Ivan Korotkov, 2012-08-17 08:09:09]

protector/ LGTM

[commit-bot: I haz the power, 2012-08-17 18:07:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yefim@chromium.org/10824344/10001

[commit-bot: I haz the power, 2012-08-17 22:39:08]

Change committed as 152173