Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 10824342: Attached data cleanup. (Closed)

Created:
8 years, 4 months ago by Avi (use Gerrit)
Modified:
8 years, 4 months ago
Reviewers:
brettw, jam, Matt Perry
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Attached data cleanup. Clean up comments on SupportsUserData. Fix typos in ResourceContextImpl. Remove use of PropertyBag from ExtensionService as it hasn't been used since r135419. Remove use of PropertyBag from RenderWidgetHostImpl as it hasn't been used since r83122. BUG=141177 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M base/supports_user_data.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/resource_context_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
John: content aa: extensions
8 years, 4 months ago (2012-08-16 23:15:29 UTC) #1
Avi (use Gerrit)
and Brett for OWNERship over base/
8 years, 4 months ago (2012-08-16 23:16:50 UTC) #2
jam
lgtm
8 years, 4 months ago (2012-08-17 00:16:01 UTC) #3
brettw
base lgtm
8 years, 4 months ago (2012-08-19 22:40:43 UTC) #4
Avi (use Gerrit)
Matt, can you take this?
8 years, 4 months ago (2012-08-20 16:20:39 UTC) #5
Matt Perry
lgtm
8 years, 4 months ago (2012-08-20 18:33:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10824342/1
8 years, 4 months ago (2012-08-20 18:37:13 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:58:23 UTC) #8
Change committed as 152421

Powered by Google App Engine
This is Rietveld 408576698