Run the disk cache tests in scoped temporary directories instead of a fixed directory so that they …

Run the disk cache tests in scoped temporary directories instead of a fixed directory so that they can run in parallel.

BUG=139272
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151999

[rvargas (doing something else), 2012-08-16 21:04:19]

http://codereview.chromium.org/10824336/diff/8003/net/disk_cache/disk_cache_t...
File net/disk_cache/disk_cache_test_util.h (left):

http://codereview.chromium.org/10824336/diff/8003/net/disk_cache/disk_cache_t...
net/disk_cache/disk_cache_test_util.h:23: FilePath GetCacheFilePath();
Still need this (at the very least for stress tests, but I also had planned to
make the use of a fixed/random directory optional).

http://codereview.chromium.org/10824336/diff/8003/net/disk_cache/stress_cache.cc
File net/disk_cache/stress_cache.cc (right):

http://codereview.chromium.org/10824336/diff/8003/net/disk_cache/stress_cache...
net/disk_cache/stress_cache.cc:106: CHECK(path.CreateUniqueTempDir());
This should definitely not be a random folder.

[jam, 2012-08-16 21:33:03]

http://codereview.chromium.org/10824336/diff/8003/net/disk_cache/stress_cache.cc
File net/disk_cache/stress_cache.cc (right):

http://codereview.chromium.org/10824336/diff/8003/net/disk_cache/stress_cache...
net/disk_cache/stress_cache.cc:106: CHECK(path.CreateUniqueTempDir());
On 2012/08/16 21:04:19, rvargas wrote:
> This should definitely not be a random folder.

ah, thanks, I didn't read this test closely enough. fixed.

[rvargas (doing something else), 2012-08-16 22:26:43]

http://codereview.chromium.org/10824336/diff/2003/net/disk_cache/stress_cache.cc
File net/disk_cache/stress_cache.cc (right):

http://codereview.chromium.org/10824336/diff/2003/net/disk_cache/stress_cache...
net/disk_cache/stress_cache.cc:80: ScopedTempDir path;
Sorry, what I meant is that stress tests as a whole should run with a fixed
folder.

This is not something that runs on any bot and there is no advantage to use a
scoped folder. On the other hand, running the executable again (and expecting it
to continue where it was interrupted) is a very common use case, as is the case
of going to the well known destination folder and inspect or run other tools on
that folder.

The simplest thing is to leave this file alone.

[jam, 2012-08-16 22:39:10]

ptal

[rvargas (doing something else), 2012-08-16 22:50:32]

lgtm