Disable compiler option 'mimplicit-it' for Android ARM

Disable compiler option 'mimplicit-it' for Android ARM

Android NDK toolchain doesn't support it.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152315

[yongsheng, 2012-08-16 09:52:31]

mark, could you please help review it?

[Mark Mentovai, 2012-08-16 12:34:59]

http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp#newcode525
breakpad/breakpad.gyp:525: ['target_arch=="arm"', {
Make this target_arch=="arm" && OS!="android" instead.

http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp#newcode533
breakpad/breakpad.gyp:533: # Android NDK toolchain doesn't support it
It? What?

[yongsheng, 2012-08-17 01:35:33]

You can see the similar issue in build/common.gypi:
# Android toolchain doesn't support -mimplicit-it=thumb
2247                         'cflags!': [ '-Wa,-mimplicit-it=thumb', ],


Thanks for the review.

http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp#newcode525
breakpad/breakpad.gyp:525: ['target_arch=="arm"', {
On 2012/08/16 12:34:59, Mark Mentovai wrote:
> Make this target_arch=="arm" && OS!="android" instead.
ok

http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp#newcode533
breakpad/breakpad.gyp:533: # Android NDK toolchain doesn't support it
On 2012/08/16 12:34:59, Mark Mentovai wrote:
> It? What?
yes, See the message:
Assembler messages:
Error: unrecognized option -mimplicit-it=always

[Mark Mentovai, 2012-08-17 14:04:00]

http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp#newcode533
breakpad/breakpad.gyp:533: # Android NDK toolchain doesn't support it
yongsheng wrote:
> On 2012/08/16 12:34:59, Mark Mentovai wrote:
> > It? What?
> yes, See the message:
> Assembler messages:
> Error: unrecognized option -mimplicit-it=always

I understand. I’m saying that your comment isn’t clear. It says “Android NDK
toolchain doesn’t support it,” and when I read that comment, I say “it? what?
what ‘it’ are you talking about?”

If it doesn’t support -mimplicit-it, the comment should say so.

# The Android NDK toolchain doesn't support -mimplicit-it.

You referred me to a similar line in common.gypi, which has a much better
comment (more like the one I’m proposing.)

[yongsheng, 2012-08-20 01:43:58]

On 2012/08/17 14:04:00, Mark Mentovai wrote:
> http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp
> File breakpad/breakpad.gyp (right):
> 
>
http://codereview.chromium.org/10824330/diff/1/breakpad/breakpad.gyp#newcode533
> breakpad/breakpad.gyp:533: # Android NDK toolchain doesn't support it
> yongsheng wrote:
> > On 2012/08/16 12:34:59, Mark Mentovai wrote:
> > > It? What?
> > yes, See the message:
> > Assembler messages:
> > Error: unrecognized option -mimplicit-it=always
> 
> I understand. I’m saying that your comment isn’t clear. It says “Android NDK
> toolchain doesn’t support it,” and when I read that comment, I say “it? what?
> what ‘it’ are you talking about?”
> 
> If it doesn’t support -mimplicit-it, the comment should say so.
> 
> # The Android NDK toolchain doesn't support -mimplicit-it.
> 
> You referred me to a similar line in common.gypi, which has a much better
> comment (more like the one I’m proposing.)
ok, sorry for my misunderstanding. here it is. Thanks.

[Mark Mentovai, 2012-08-20 02:05:02]

LGTM

[commit-bot: I haz the power, 2012-08-20 09:53:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10824330/7001

[commit-bot: I haz the power, 2012-08-20 12:16:58]

Change committed as 152315