Reduce number of expensive calls to List.redraw() during load of settings page.

Reduce number of expensive calls to List.redraw() during load of settings page.

- Removed unnecessary List.redraw calls from
      -- network_list.js
      -- autofill_edit_address_overlay.js
      -- content_settings_exceptions_area.js
- Added an early return to List.redraw() for the case clientHeight == 0 (eg. if the list is not visible).
- Some small cleanup.

Overall there were about 68 expensive (ie. no early return) calls to redraw() which I could reduce to 26. The speedup is about 7% / 28ms for the "onload" event on my desktop machine.

BUG=143116
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152153

[pneubeck (no reviews), 2012-08-16 09:33:57]

Please take a look at this cleanup to speedup loading the settings page.

[arv (Not doing code reviews), 2012-08-16 15:29:37]

LGTM

https://chromiumcodereview.appspot.com/10824328/diff/1/chrome/browser/resourc...
File chrome/browser/resources/options2/autofill_edit_address_overlay.js (right):

https://chromiumcodereview.appspot.com/10824328/diff/1/chrome/browser/resourc...
chrome/browser/resources/options2/autofill_edit_address_overlay.js:103:
list.dataModel = new ArrayDataModel(augmentedList);
Good catch

https://chromiumcodereview.appspot.com/10824328/diff/1/chrome/browser/resourc...
File chrome/browser/resources/shared/js/cr/ui/list.js (right):

https://chromiumcodereview.appspot.com/10824328/diff/1/chrome/browser/resourc...
chrome/browser/resources/shared/js/cr/ui/list.js:951: * Doesn't delete {@code
this.pinnedItem_} if it is present (instead hides
instead hides _it_ if it is out of the range

https://chromiumcodereview.appspot.com/10824328/diff/1/chrome/browser/resourc...
chrome/browser/resources/shared/js/cr/ui/list.js:1091: if (!dataModel ||
(!this.autoExpands_ && this.clientHeight == 0)) {
useless parentheses

[pneubeck (no reviews), 2012-08-17 11:35:11]

Addressed the comments.

http://codereview.chromium.org/10824328/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/autofill_edit_address_overlay.js (right):

http://codereview.chromium.org/10824328/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/autofill_edit_address_overlay.js:103:
list.dataModel = new ArrayDataModel(augmentedList);
On 2012/08/16 15:29:37, arv wrote:
> Good catch

Done.

http://codereview.chromium.org/10824328/diff/1/chrome/browser/resources/share...
File chrome/browser/resources/shared/js/cr/ui/list.js (right):

http://codereview.chromium.org/10824328/diff/1/chrome/browser/resources/share...
chrome/browser/resources/shared/js/cr/ui/list.js:951: * Doesn't delete {@code
this.pinnedItem_} if it is present (instead hides
On 2012/08/16 15:29:37, arv wrote:
> instead hides _it_ if it is out of the range

Done.

http://codereview.chromium.org/10824328/diff/1/chrome/browser/resources/share...
chrome/browser/resources/shared/js/cr/ui/list.js:1091: if (!dataModel ||
(!this.autoExpands_ && this.clientHeight == 0)) {
On 2012/08/16 15:29:37, arv wrote:
> useless parentheses

Done.

[commit-bot: I haz the power, 2012-08-17 14:42:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/10824328/4001

[commit-bot: I haz the power, 2012-08-17 22:25:36]

Change committed as 152153