Issue 10824325: don't use COMPILER_MSVC in pp_macros.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824325: don't use COMPILER_MSVC in pp_macros.h (Closed)

Created:
8 years, 4 months ago by Sam Clegg

Modified:
8 years, 4 months ago

Reviewers:
brettw, viettrungluu

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

don't use COMPILER_MSVC in pp_macros.h COMPILER_MSVC is defined in build_config.h which doesn't seem to be available externally to plugin developers (at least not with the NaCL SDK). Instead use _MSC_VER which is already used elsewhere in this file. R=viettrungluu@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152480

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	ppapi/api/pp_macros.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ppapi/c/pp_macros.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10824325/1

8 years, 4 months ago (2012-08-17 21:14:01 UTC) #4

commit-bot: I haz the power

Try job failure for 10824325-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...

8 years, 4 months ago (2012-08-18 00:55:43 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10824325/1

8 years, 4 months ago (2012-08-20 22:30:20 UTC) #6

Change committed as 152480

Expand Messages | Collapse Messages