chrome/browser/favicon/favicon_handler_unittest.cc - Issue 10824319: Give SelectFaviconFrames a quality score.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 10824319: Give SelectFaviconFrames a quality score. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler_unittest.cc

diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc

index bcf438343a04ece407deeea09d289a1124db2a01..50ad60cc9aeea6ddbd76ac5bffeabb65cce1da91 100644

--- a/chrome/browser/favicon/favicon_handler_unittest.cc

+++ b/chrome/browser/favicon/favicon_handler_unittest.cc

@@ -301,7 +301,8 @@ void DownloadHandler::InvokeCallback() {

FillDataToBitmap(bitmap_size, bitmap_size, &bitmap);

gfx::Image image(bitmap);

favicon_helper_->OnDidDownloadFavicon(

- download_->download_id, download_->image_url, failed_, image);

+ download_->download_id, download_->image_url, failed_, image,

+ download_->image_size == gfx::kFaviconSize);

}

class FaviconHandlerTest : public ChromeRenderViewHostTestHarness {