Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3460)

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 10824319: Give SelectFaviconFrames a quality score. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | chrome/browser/favicon/favicon_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler.h
diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h
index 77ffe3e97437fe346c631925aa5b7511310bbc64..02b2f818de44507edaeead2d46b6bf6853528d97 100644
--- a/chrome/browser/favicon/favicon_handler.h
+++ b/chrome/browser/favicon/favicon_handler.h
@@ -115,7 +115,8 @@ class FaviconHandler {
void OnDidDownloadFavicon(int id,
const GURL& image_url,
bool errored,
- const gfx::Image& image);
+ const gfx::Image& image,
+ float score);
// For testing.
const std::deque<FaviconURL>& image_urls() const { return image_urls_; }
@@ -186,13 +187,13 @@ class FaviconHandler {
FaviconCandidate(const GURL& url,
const GURL& image_url,
const gfx::Image& image,
- int bitmap_size,
+ float score,
history::IconType icon_type);
GURL url;
GURL image_url;
gfx::Image image;
- int bitmap_size;
+ float score;
history::IconType icon_type;
};
@@ -223,6 +224,7 @@ class FaviconHandler {
bool UpdateFaviconCandidate(const GURL& url,
const GURL& image_url,
const gfx::Image& image,
+ float score,
history::IconType icon_type);
// Sets the image data for the favicon.
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | chrome/browser/favicon/favicon_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698