Issue 10824316: Avoid calling GetNamedPipeClientProcessId() which is not available on XP.

Issue 10824316: Avoid calling GetNamedPipeClientProcessId() which is not available on XP. (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)

Modified:
8 years, 4 months ago

Reviewers:
Sergey Ulanov, dcaiafa

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Avoid calling GetNamedPipeClientProcessId() which is not available on XP. BUG=121496 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151816

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -26 lines)			Patch
M	remoting/host/win/worker_process_launcher.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	remoting/host/win/worker_process_launcher.cc	View	1	1 chunk	+9 lines, -10 lines	0 comments	Download
M	remoting/host/win/wts_session_process_launcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/win/wts_session_process_launcher.cc	View		1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

dcaiafa

lgtm ... for all the good it will do you since I'm a lowly non-committer. ...

8 years, 4 months ago (2012-08-15 20:44:32 UTC) #2

alexeypa (please no reviews)

Sergey, could you please rubber stamp? https://chromiumcodereview.appspot.com/10824316/diff/1/remoting/host/win/worker_process_launcher.cc File remoting/host/win/worker_process_launcher.cc (right): https://chromiumcodereview.appspot.com/10824316/diff/1/remoting/host/win/worker_process_launcher.cc#newcode117 remoting/host/win/worker_process_launcher.cc:117: // If we'd ...

8 years, 4 months ago (2012-08-15 21:15:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10824316/5001

8 years, 4 months ago (2012-08-15 22:12:22 UTC) #5

commit-bot: I haz the power

Try job failure for 10824316-5001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-15 22:48:14 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10824316/5001

8 years, 4 months ago (2012-08-15 22:58:08 UTC) #7

Change committed as 151816

Expand Messages | Collapse Messages