Fix crash in browserAction.setIcon

Fix crash in browserAction.setIcon

Crash occurs when icon we set is empty.

BUG=142908
TEST=manual

NOTE: I'll add test for this later.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151776

[Jeffrey Yasskin, 2012-08-15 18:11:33]

LGTM, but isn't that a bug in gfx::Image? Empty images should convert to empty
images, not null pointers.

[tbarzic, 2012-08-15 18:36:18]

On 2012/08/15 18:11:33, Jeffrey Yasskin wrote:
> LGTM, but isn't that a bug in gfx::Image? Empty images should convert to empty
> images, not null pointers.

actually no, ToImageSkia intentionally crashes for empty image.

but, there I a method I missed that does what we want :)

PTAL

[Jeffrey Yasskin, 2012-08-15 18:42:18]

LGTM

Thank you for the new methods Nico!

[Mihai Parparita -not on Chrome, 2012-08-15 19:01:18]

LGTM

[commit-bot: I haz the power, 2012-08-15 19:01:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/10824314/4001

[commit-bot: I haz the power, 2012-08-15 19:33:11]

Try job failure for 10824314-4001 on mac_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-15 19:57:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/10824314/4

[commit-bot: I haz the power, 2012-08-15 23:02:18]

Change committed as 151776