Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 10824309: Adding unit test to check for incorrect mouse enter/exit event handling (Closed)

Created:
8 years, 4 months ago by Mr4D (OOO till 08-26)
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Adding unit test to check for incorrect mouse enter/exit event handling BUG=142355 TEST=Unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151925

Patch Set 1 #

Patch Set 2 : Rewritten unit tests #

Total comments: 2

Patch Set 3 : Changed names as requested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -1 line) Patch
M ui/views/widget/widget_unittest.cc View 1 2 2 chunks +77 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mr4D (OOO till 08-26)
As promised - the unit test for the missing events. This CL will go in ...
8 years, 4 months ago (2012-08-15 16:13:00 UTC) #1
sky
The test should be as close to the fix as possible. You should add it ...
8 years, 4 months ago (2012-08-15 16:55:54 UTC) #2
Mr4D (OOO till 08-26)
Rewritten the test to your comment. Please look again.
8 years, 4 months ago (2012-08-15 23:26:20 UTC) #3
sky
LGTM with the following change. http://codereview.chromium.org/10824309/diff/1002/ui/views/widget/widget_unittest.cc File ui/views/widget/widget_unittest.cc (right): http://codereview.chromium.org/10824309/diff/1002/ui/views/widget/widget_unittest.cc#newcode94 ui/views/widget/widget_unittest.cc:94: int CheckEnteredCalls() { Can ...
8 years, 4 months ago (2012-08-16 00:38:15 UTC) #4
Mr4D (OOO till 08-26)
Done and submitted. Thanks! http://codereview.chromium.org/10824309/diff/1002/ui/views/widget/widget_unittest.cc File ui/views/widget/widget_unittest.cc (right): http://codereview.chromium.org/10824309/diff/1002/ui/views/widget/widget_unittest.cc#newcode94 ui/views/widget/widget_unittest.cc:94: int CheckEnteredCalls() { On 2012/08/16 ...
8 years, 4 months ago (2012-08-16 16:04:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10824309/6002
8 years, 4 months ago (2012-08-16 16:04:36 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 18:32:35 UTC) #7
Change committed as 151925

Powered by Google App Engine
This is Rietveld 408576698