Wire-up DeleteFileSystem to DumpRenderTree

Wire-up DeleteFileSystem to DRT

DeleteFileSystem will be used in Inspector to allow web developers to clear their filesystem.
And DRT support of DeleteFileSystem will help unittest of Inspector.

BUG=139366
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151836

[tzik, 2012-08-15 06:06:28]

Kinuko-san & Kent-san, I'd like to use DeleteFileSystem from DumpRenderTree.
Can I add it like this?

[kinuko, 2012-08-15 06:15:58]

http://codereview.chromium.org/10824305/diff/1/webkit/tools/test_shell/simple...
File webkit/tools/test_shell/simple_file_system.cc (right):

http://codereview.chromium.org/10824305/diff/1/webkit/tools/test_shell/simple...
webkit/tools/test_shell/simple_file_system.cc:126: return;
We silently return success in RenderViewImpl in this case.  Maybe we should do
the same?

http://codereview.chromium.org/10824305/diff/1/webkit/tools/test_shell/simple...
webkit/tools/test_shell/simple_file_system.cc:135: type =
fileapi::kFileSystemTypeExternal;
These explicit assignments are not really necessary.  Maybe we should just pass
the type to FileSystemContext and let it handle unknown type cases? (Probably we
should do the same in OpenFileSystem)

[tkent, 2012-08-15 06:18:53]

> Wire-up DeleteFileSystem to DRT

Why do you need DeleteFileSystem?
The change description should have such information.

[tzik, 2012-08-15 06:53:36]

Thanks, I updated the CL and its description.

Could you take another look?

http://codereview.chromium.org/10824305/diff/1/webkit/tools/test_shell/simple...
File webkit/tools/test_shell/simple_file_system.cc (right):

http://codereview.chromium.org/10824305/diff/1/webkit/tools/test_shell/simple...
webkit/tools/test_shell/simple_file_system.cc:126: return;
On 2012/08/15 06:15:58, kinuko wrote:
> We silently return success in RenderViewImpl in this case.  Maybe we should do
> the same?

We return success in RVI if the origin is unique (e.g. data: scheme URI).
I think the condition in this CL is different to RVI case.

http://codereview.chromium.org/10824305/diff/1/webkit/tools/test_shell/simple...
webkit/tools/test_shell/simple_file_system.cc:135: type =
fileapi::kFileSystemTypeExternal;
On 2012/08/15 06:15:58, kinuko wrote:
> These explicit assignments are not really necessary.  Maybe we should just
pass
> the type to FileSystemContext and let it handle unknown type cases? (Probably
we
> should do the same in OpenFileSystem)

Done.

[kinuko, 2012-08-15 06:56:59]

lgtm

[tkent, 2012-08-15 07:07:08]

LGTM for webkit/support/.

[commit-bot: I haz the power, 2012-08-15 07:10:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/10824305/4002

[commit-bot: I haz the power, 2012-08-15 07:10:35]

Presubmit check for 10824305-4002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit

[tzik, 2012-08-15 07:11:57]

On 2012/08/15 07:07:08, Kent Tamura wrote:
> LGTM for webkit/support/.

Thanks!

[tzik, 2012-08-15 07:21:08]

Tony, could you take a look to simple_file_system.{h,cc}?

[tony, 2012-08-15 23:43:43]

LGTM

[commit-bot: I haz the power, 2012-08-16 01:07:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/10824305/4002

[commit-bot: I haz the power, 2012-08-16 03:02:13]

Change committed as 151836