Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 10824300: grd changes for new assets. (Closed)

Created:
8 years, 4 months ago by varunjain
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

grd changes for new assets. BUG=137351 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151732

Patch Set 1 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -76 lines) Patch
M chrome/app/theme/theme_resources.grd View 19 chunks +68 lines, -58 lines 0 comments Download
M ui/resources/ui_resources.grd View 1 chunk +18 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
varunjain
8 years, 4 months ago (2012-08-15 13:54:22 UTC) #1
sky
Don't you need to move around the files too?
8 years, 4 months ago (2012-08-15 15:20:17 UTC) #2
varunjain
On 2012/08/15 15:20:17, sky wrote: > Don't you need to move around the files too? ...
8 years, 4 months ago (2012-08-15 15:33:05 UTC) #3
sky
LGTM
8 years, 4 months ago (2012-08-15 16:10:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10824300/8004
8 years, 4 months ago (2012-08-15 16:11:49 UTC) #5
commit-bot: I haz the power
Try job failure for 10824300-8004 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-15 17:43:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10824300/8004
8 years, 4 months ago (2012-08-15 17:46:10 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 19:50:47 UTC) #8
Change committed as 151732

Powered by Google App Engine
This is Rietveld 408576698