Adding tests for USB extension API

Adding tests for USB extension API

Includes test coverage for the recently-fixed zero-length transfer bug.

BUG=140390
TEST=self


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151777

[Garret Kelly, 2012-08-14 20:57:31]

bryeung: For chrome/browser/usb changes.

asargent: For everything else.

[Nico, 2012-08-14 21:00:22]

chrome_tests change lgtm stamp

[bryeung, 2012-08-14 21:01:28]

chrome/browser/usb lgtm

[asargent_no_longer_on_chrome, 2012-08-14 22:31:06]

LGTM

http://codereview.chromium.org/10824298/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/usb/usb_api.cc (right):

http://codereview.chromium.org/10824298/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/usb/usb_api.cc:66: DCHECK(service) << "No
UsbService associated with profile.";
nit: Since we'll crash on the next line anyway if |service| is NULL, consider
just making this a CHECK instead of DCHECK.

Alternatively, if there are legitimate scenarios where |service| could come back
NULL, then just leave |device| NULL and fall through to the CreateNullValue case
below.

http://codereview.chromium.org/10824298/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/usb/usb_api.h (right):

http://codereview.chromium.org/10824298/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/usb/usb_api.h:48: static UsbDevice*
device_for_test_;
nit: can this just be declared/defined in the .cc file as a file-local static or
in an anonymous namespace?

[Garret Kelly, 2012-08-14 23:19:48]

Thanks for the review!

> nit: Since we'll crash on the next line anyway if |service| is NULL, consider
> just making this a CHECK instead of DCHECK.

This DCHECK is actually left over from when UsbService wasn't created by the
UsbServiceFactory (a ProfileKeyedServiceFactory), so it actually can't fail now.
It'll just be instantiated if none exists. I'm going to remove this DCHECK.

> nit: can this just be declared/defined in the .cc file as a file-local static
or
> in an anonymous namespace?

Done!

[commit-bot: I haz the power, 2012-08-14 23:20:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gdk@chromium.org/10824298/9002

[commit-bot: I haz the power, 2012-08-15 00:59:08]

Try job failure for 10824298-9002 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-15 15:46:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gdk@chromium.org/10824298/1020

[commit-bot: I haz the power, 2012-08-15 20:10:08]

Try job failure for 10824298-1020 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-15 20:30:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gdk@chromium.org/10824298/1020

[commit-bot: I haz the power, 2012-08-15 23:04:20]

Change committed as 151777