Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 10824294: Changed Windows account to run service. (Closed)

Created:
8 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Removed default account for service. Added required options run-as-user and run-as-password. Added code to set security rights required to run service. File access and chrome binary checks changed from fatal error to just error message. BUG=141243 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151652

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -44 lines) Patch
M cloud_print/service/service.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cloud_print/service/service_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cloud_print/service/service_switches.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 2 12 chunks +69 lines, -44 lines 0 comments Download
A cloud_print/service/win/local_security_policy.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A cloud_print/service/win/local_security_policy.cc View 1 2 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Vitaly Buka (NO REVIEWS)
Please review.
8 years, 4 months ago (2012-08-14 19:32:01 UTC) #1
Albert Bodenhamer
https://chromiumcodereview.appspot.com/10824294/diff/7001/cloud_print/service/win/cloud_print_service.cc File cloud_print/service/win/cloud_print_service.cc (right): https://chromiumcodereview.appspot.com/10824294/diff/7001/cloud_print/service/win/cloud_print_service.cc#newcode29 cloud_print/service/win/cloud_print_service.cc:29: const wchar_t kUserToRunService[] = L"NT AUTHORITY\\SYSTEM"; I'm a bit ...
8 years, 4 months ago (2012-08-14 20:38:18 UTC) #2
Vitaly Buka (NO REVIEWS)
https://chromiumcodereview.appspot.com/10824294/diff/7001/cloud_print/service/win/cloud_print_service.cc File cloud_print/service/win/cloud_print_service.cc (right): https://chromiumcodereview.appspot.com/10824294/diff/7001/cloud_print/service/win/cloud_print_service.cc#newcode29 cloud_print/service/win/cloud_print_service.cc:29: const wchar_t kUserToRunService[] = L"NT AUTHORITY\\SYSTEM"; For current user ...
8 years, 4 months ago (2012-08-14 20:58:51 UTC) #3
Vitaly Buka (NO REVIEWS)
https://chromiumcodereview.appspot.com/10824294/diff/7001/cloud_print/service/win/cloud_print_service.cc File cloud_print/service/win/cloud_print_service.cc (right): https://chromiumcodereview.appspot.com/10824294/diff/7001/cloud_print/service/win/cloud_print_service.cc#newcode29 cloud_print/service/win/cloud_print_service.cc:29: const wchar_t kUserToRunService[] = L"NT AUTHORITY\\SYSTEM"; Removed default user. ...
8 years, 4 months ago (2012-08-14 21:51:00 UTC) #4
Albert Bodenhamer
lgtm
8 years, 4 months ago (2012-08-14 22:32:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10824294/10009
8 years, 4 months ago (2012-08-14 22:55:41 UTC) #6
commit-bot: I haz the power
Try job failure for 10824294-10009 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 4 months ago (2012-08-15 00:31:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10824294/10009
8 years, 4 months ago (2012-08-15 00:31:57 UTC) #8
commit-bot: I haz the power
Try job failure for 10824294-10009 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-15 02:10:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10824294/10009
8 years, 4 months ago (2012-08-15 02:11:52 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 04:25:55 UTC) #11
Change committed as 151652

Powered by Google App Engine
This is Rietveld 408576698