Add a build target for perf_av bot dependencies.

Add a build target for perf_av bot dependencies.


BUG=142495
TEST=rm -rf out, build chromium_builder_perf_av, run  functional/media/ pyauto tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151578

[shadi, 2012-08-13 23:32:50]

Dale,

Are there other steps needed to add a build target?

[DaleCurtis, 2012-08-14 00:19:18]

On 2012/08/13 23:32:50, shadi wrote:
> Dale,
> 
> Are there other steps needed to add a build target?

This looks correct, but I don't know if this is the right thing to do or not. 
You should add cmp or another infrastructure reviewer.

[shadi, 2012-08-14 00:26:51]

On 2012/08/14 00:19:18, DaleCurtis wrote:
> On 2012/08/13 23:32:50, shadi wrote:
> > Dale,
> > 
> > Are there other steps needed to add a build target?
> 
> This looks correct, but I don't know if this is the right thing to do or not. 
> You should add cmp or another infrastructure reviewer.

Sure, this was actually the result of discussion with cmp@.

+cmp for LGTM :)

[cmp, 2012-08-14 00:31:41]

lgtm with a question (i think you need chromium_builder_perf rather than
chromium_builder_qa) and some nits

https://chromiumcodereview.appspot.com/10824287/diff/1/build/all.gyp
File build/all.gyp (right):

https://chromiumcodereview.appspot.com/10824287/diff/1/build/all.gyp#newcode338
build/all.gyp:338: 'chromium_builder_qa', # needed for pyauto
do you not need chromium_builder_perf (a superset of chromium_builder_qa) for
perf tests, too?

indent comment '# needed for pyauto' by one more space

https://chromiumcodereview.appspot.com/10824287/diff/1/build/all.gyp#newcode339
build/all.gyp:339: '../webkit/webkit.gyp:pull_in_DumpRenderTree', # to run
layout tests
indent comment '# to run layout tests' by one more space

https://chromiumcodereview.appspot.com/10824287/diff/1/build/all.gyp#newcode341
build/all.gyp:341: }, # target_name: chromium_builder_perf_av
indent this comment by one more space

[shadi, 2012-08-14 17:41:03]

I am not sure I really need chromium_builder_perf.  Please see comments and let
me know.

https://chromiumcodereview.appspot.com/10824287/diff/1/build/all.gyp
File build/all.gyp (right):

https://chromiumcodereview.appspot.com/10824287/diff/1/build/all.gyp#newcode338
build/all.gyp:338: 'chromium_builder_qa', # needed for pyauto
On 2012/08/14 00:31:41, cmp wrote:
> do you not need chromium_builder_perf (a superset of chromium_builder_qa) for
> perf tests, too?
> 
> indent comment '# needed for pyauto' by one more space
I do not run browser_tests or ui_tests that are built with
chromium_builder_perf.  I only need pyauto to work.  To check, I did  'rm -rf
out' and built chromium_builder_perf_av and verified couple of functional/media/
pyauto tests.

https://chromiumcodereview.appspot.com/10824287/diff/1/build/all.gyp#newcode339
build/all.gyp:339: '../webkit/webkit.gyp:pull_in_DumpRenderTree', # to run
layout tests
On 2012/08/14 00:31:41, cmp wrote:
> indent comment '# to run layout tests' by one more space

Done.

https://chromiumcodereview.appspot.com/10824287/diff/1/build/all.gyp#newcode341
build/all.gyp:341: }, # target_name: chromium_builder_perf_av
On 2012/08/14 00:31:41, cmp wrote:
> indent this comment by one more space

Done.

[cmp, 2012-08-14 17:41:52]

lgtm then

[commit-bot: I haz the power, 2012-08-14 17:43:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/10824287/1003

[commit-bot: I haz the power, 2012-08-14 22:04:41]

Change committed as 151578