Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 10824285: gcapi/mac: Prevent "unknown binary" stderr output from sudo (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

gcapi/mac: Prevent "unknown binary" stderr output from sudo BUG=151345 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/installer/gcapi_mac/gcapi.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
The code seems to mostly work as is. The only issue I found was that ...
8 years, 4 months ago (2012-08-13 21:22:27 UTC) #1
Mark Mentovai
I like this better than setting up a pipe for stderr, because if there are ...
8 years, 4 months ago (2012-08-13 21:57:16 UTC) #2
Nico
8 years, 4 months ago (2012-08-13 21:59:23 UTC) #3
On Mon, Aug 13, 2012 at 2:57 PM,  <mark@chromium.org> wrote:
> I like this better than setting up a pipe for stderr, because if there are
> other errors, you’d probably want them to just get spewed out to stderr.
>
> LGTM

Right, that was my reasoning too. Thanks!

Powered by Google App Engine
This is Rietveld 408576698