Issue 10824281: Defer OMX Flush() when no input buffers are available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824281: Defer OMX Flush() when no input buffers are available. (Closed)

Created:
8 years, 4 months ago by Ami GONE FROM CHROMIUM

Modified:
8 years, 4 months ago

Reviewers:
Pawel Osciak, scherkus (not reviewing)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Defer OMX Flush() when no input buffers are available. E.g. this makes the video_decode ppapi example not error out at EOS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151337

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -13 lines)			Patch
	M	content/common/gpu/media/omx_video_decode_accelerator.cc	View		5 chunks	+21 lines, -12 lines	0 comments	Download
	M	ppapi/examples/video_decode/video_decode.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

8 years, 4 months ago (2012-08-13 18:48:15 UTC) #3

Ami GONE FROM CHROMIUM

scherkus: i can haz super-star reviewer LGTY?

8 years, 4 months ago (2012-08-13 18:51:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10824281/1

8 years, 4 months ago (2012-08-13 19:39:01 UTC) #6

Change committed as 151337