Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 10824268: Turn off cygwin for grit again. (Closed)

Created:
8 years, 4 months ago by iannucci
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Turn off cygwin for grit again. Roll gyp has already been updated prevent the issues which happened previously with msvs 2008. This is a second attempt at https://chromiumcodereview.appspot.com/10832121/ BUG=123026 R=scottmg,joi,thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152639

Patch Set 1 #

Patch Set 2 : git try -c #

Patch Set 3 : rebased #

Patch Set 4 : Remove gyp roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/grit_action.gypi View 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
iannucci
Ok. So I ran this through win_rel (noclobber) and win_rel (clobber). Interestingly, the clobber build ...
8 years, 4 months ago (2012-08-11 00:25:58 UTC) #1
scottmg
On 2012/08/11 00:25:58, iannucci wrote: > Ok. So I ran this through win_rel (noclobber) and ...
8 years, 4 months ago (2012-08-11 00:29:59 UTC) #2
iannucci
On 2012/08/11 00:29:59, scottmg wrote: > On 2012/08/11 00:25:58, iannucci wrote: > > Ok. So ...
8 years, 4 months ago (2012-08-11 00:31:59 UTC) #3
iannucci
On 2012/08/11 00:31:59, iannucci wrote: > On 2012/08/11 00:29:59, scottmg wrote: > > On 2012/08/11 ...
8 years, 4 months ago (2012-08-11 00:38:36 UTC) #4
iannucci
On 2012/08/11 00:38:36, iannucci wrote: > On 2012/08/11 00:31:59, iannucci wrote: > > On 2012/08/11 ...
8 years, 4 months ago (2012-08-11 01:58:53 UTC) #5
iannucci
PTAL again: If you agree that the fails aren't due to the change, I'll add ...
8 years, 4 months ago (2012-08-21 18:28:07 UTC) #6
scottmg
On 2012/08/21 18:28:07, iannucci wrote: > PTAL again: If you agree that the fails aren't ...
8 years, 4 months ago (2012-08-21 18:35:10 UTC) #7
joi
They don't look related but I would also suggest just pulling the CQ trigger again. ...
8 years, 4 months ago (2012-08-21 19:22:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/10824268/6009
8 years, 4 months ago (2012-08-21 19:53:02 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 21:25:43 UTC) #10
Change committed as 152639

Powered by Google App Engine
This is Rietveld 408576698