Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: vm/code_generator.h

Issue 10824266: Remove functions_cache_ and it's references as it is not being used anymore. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/code_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/code_generator.h
===================================================================
--- vm/code_generator.h (revision 10541)
+++ vm/code_generator.h (working copy)
@@ -84,47 +84,7 @@
#undef DEFINE_ENUM_LIST
};
-// This class wraps around the array RawClass::functions_cache_.
-// The structure of that array is specified by FunctionsCache::Entries.
-// The last entry in the array is always NULL, the lookup code can rely on
-// last entry being NULL to terminate its search.
-// The compiled functions are added sequentially (except for the last entry
-// being empty). Names of functions with variable number of arguments
-// can appear several times, once for each valid argument count.
-class FunctionsCache : public ValueObject {
- public:
- // Entries in the RawClass::functions_cache_. The size of initially allocated
- // functions_cache_ array is (kInitialSize * kNumEntries).
- enum Entries {
- kFunctionName = 0,
- kArgCount = 1,
- kNamedArgCount = 2,
- kFunction = 3,
- kNumEntries = 4
- };
- explicit FunctionsCache(const Class& cls) : class_(cls) {}
-
- void AddCompiledFunction(const Function& function,
- int num_arguments,
- int num_named_arguments);
-
- // This is a testing function, the lookup (will) occur inlined in stub code.
- RawCode* LookupCode(const String& function_name,
- int num_arguments,
- int num_named_arguments);
-
- private:
- static void EnterFunctionAt(int i,
- const Array& cache,
- const Function& function,
- int num_arguments,
- int num_named_arguments);
-
- const Class& class_;
-};
-
-
RawCode* ResolveCompileInstanceCallTarget(Isolate* isolate,
const Instance& receiver);
« no previous file with comments | « no previous file | vm/code_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698